chrome/common/worker_thread_ticker_unittest.cc - Issue 8873032: Removing MessageLoop::QuitTask() from chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/worker_thread_ticker_unittest.cc

Issue 8873032: Removing MessageLoop::QuitTask() from chrome/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Revert 3 more problematic files Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/worker_thread_ticker_unittest.cc

diff --git a/chrome/common/worker_thread_ticker_unittest.cc b/chrome/common/worker_thread_ticker_unittest.cc

index b3e1f083506cb3761ae5f5e42551eba6ac05f3e3..b999c3372a711e73201beab4731465acfeec97b0 100644

--- a/chrome/common/worker_thread_ticker_unittest.cc

+++ b/chrome/common/worker_thread_ticker_unittest.cc

@@ -19,7 +19,7 @@ class TestCallback : public WorkerThreadTicker::Callback {

counter_++;

// Finish the test faster.

- message_loop_->PostTask(FROM_HERE, new MessageLoop::QuitTask());

+ message_loop_->PostTask(FROM_HERE, MessageLoop::QuitClosure());

}

int counter() const { return counter_; }

@@ -38,7 +38,7 @@ class LongCallback : public WorkerThreadTicker::Callback {

void RunMessageLoopForAWhile() {

MessageLoop::current()->PostDelayedTask(FROM_HERE,

- new MessageLoop::QuitTask(), 500);

+ MessageLoop::QuitClosure(), 500);

MessageLoop::current()->Run();

}