chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_hover_state_unittest.mm - Issue 8873032: Removing MessageLoop::QuitTask() from chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_hover_state_unittest.mm

Issue 8873032: Removing MessageLoop::QuitTask() from chrome/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Revert 3 more problematic files Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/glue/http_bridge_unittest.cc ('k') | chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_hover_state_unittest.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_hover_state_unittest.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_hover_state_unittest.mm

index 2cab85f6d06d808bc2adaf6209e00f1b49b6c194..a6ce4cbb7417ecea15cedcc2ba88dcfd7aed5e5a 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_hover_state_unittest.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_hover_state_unittest.mm

@@ -47,7 +47,7 @@ TEST_F(BookmarkBarFolderHoverStateTest, HoverState) {

// Test transition from opening to opened.

message_loop.PostDelayedTask(

FROM_HERE,

- new MessageLoop::QuitTask,

+ MessageLoop::QuitClosure(),

bookmarks::kDragHoverOpenDelay * 1000.0 * 1.5);

message_loop.Run();

ASSERT_EQ(kHoverStateOpen, [bbfhs hoverState]);

@@ -67,7 +67,7 @@ TEST_F(BookmarkBarFolderHoverStateTest, HoverState) {

ASSERT_EQ(kHoverStateClosing, [bbfhs hoverState]);

message_loop.PostDelayedTask(

FROM_HERE,

- new MessageLoop::QuitTask,

+ MessageLoop::QuitClosure(),

bookmarks::kDragHoverCloseDelay * 1000.0 * 1.5);

message_loop.Run();

ASSERT_EQ(kHoverStateClosed, [bbfhs hoverState]);