Issue 8872053: Add world_id parameter to ExtensionDispatcher::AllowScriptExecution().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8872053: Add world_id parameter to ExtensionDispatcher::AllowScriptExecution(). (Closed)

Created:
9 years ago by koz (OOO until 15th September)

Modified:
9 years ago

Reviewers:
not at google - send to devlin, aa

CC:
chromium-reviews, jstritar+watch_chromium.org, darin-cc_chromium.org, mihaip+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Add world_id parameter to ExtensionDispatcher::AllowScriptExecution(). This is the first step in a double-sided patch to plumb this extra argument from webkit. BUG=80310 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114334

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -0 lines)			Patch
M	chrome/renderer/chrome_render_view_observer.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/renderer/chrome_render_view_observer.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/renderer/extensions/extension_dispatcher.h	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/renderer/extensions/extension_dispatcher.cc	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

Aaron Boodman

LGTM Did you take a look at what it would take to do this in ...

9 years ago (2011-12-09 16:19:04 UTC) #2

koz (OOO until 15th September)

On 2011/12/09 16:19:04, Aaron Boodman wrote: > LGTM > > Did you take a look ...

9 years ago (2011-12-09 22:29:22 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/koz@chromium.org/8872053/1005

9 years ago (2011-12-14 00:22:10 UTC) #4

Change committed as 114334