Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1887)

Unified Diff: media/audio/mac/audio_output_mac.cc

Issue 8872028: Make check for 'opened' consistent across all audio stream implementations of Start() and log an ... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/audio/mac/audio_output_mac.cc
===================================================================
--- media/audio/mac/audio_output_mac.cc (revision 113210)
+++ media/audio/mac/audio_output_mac.cc (working copy)
@@ -479,6 +479,10 @@
void PCMQueueOutAudioOutputStream::Start(AudioSourceCallback* callback) {
DCHECK(callback);
+ DLOG_IF(ERROR, !audio_queue_) << "Must call Open() first";
+ if (!audio_queue_)
+ return;
+
OSStatus err = noErr;
SetSource(callback);
pending_bytes_ = 0;

Powered by Google App Engine
This is Rietveld 408576698