Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(918)

Unified Diff: media/audio/pulse/pulse_output.cc

Issue 8872028: Make check for 'opened' consistent across all audio stream implementations of Start() and log an ... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/audio/pulse/pulse_output.cc
===================================================================
--- media/audio/pulse/pulse_output.cc (revision 113210)
+++ media/audio/pulse/pulse_output.cc (working copy)
@@ -383,8 +383,11 @@
void PulseAudioOutputStream::Start(AudioSourceCallback* callback) {
DCHECK_EQ(message_loop_, MessageLoop::current());
+ CHECK(callback);
+ DLOG_IF(ERROR, !playback_handle_) << "Must call Open() first";
+ if (!playback_handle_)
+ return;
- CHECK(callback);
source_callback_ = callback;
// Clear buffer, it might still have data in it.

Powered by Google App Engine
This is Rietveld 408576698