Issue 8865008: Revert 113479 - Revert "Revert 113250 - Add CommandBuffer::SetGetBuffer"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8865008: Revert 113479 - Revert "Revert 113250 - Add CommandBuffer::SetGetBuffer" (Closed)

Created:
9 years ago by Raghu Simha

Modified:
9 years ago

Reviewers:
greggman

CC:
chromium-reviews, jam, yzshen+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, apatrick_chromium, Paweł Hajdan Jr., piman+watch_chromium.org, ihf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 113479 - Revert "Revert 113250 - Add CommandBuffer::SetGetBuffer" Reason for revert: Bot redness. See http://build.chromium.org/p/chromium/builders/Mac10.6%20Tests%20%281%29/builds/15717 Original checkin notes: This reverts commit bd45bd252aeb8babac62547a5c605fbf64287cd3. TEST=ran webkit tests in DRT and webgl tests in chrome BUG=103989 Review URL: http://codereview.chromium.org/8758026 TBR=gman@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113512

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+541 lines, -504 lines)			Patch
M	content/common/gpu/gpu_command_buffer_stub.h	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	content/common/gpu/gpu_command_buffer_stub.cc	View	5 chunks	+15 lines, -12 lines	0 comments	Download
M	content/common/gpu/gpu_messages.h	View	1 chunk	+3 lines, -5 lines	0 comments	Download
M	content/renderer/gpu/command_buffer_proxy.h	View	2 chunks	+7 lines, -2 lines	0 comments	Download
M	content/renderer/gpu/command_buffer_proxy.cc	View	4 chunks	+62 lines, -10 lines	0 comments	Download
M	content/renderer/gpu/renderer_gl_context.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/command_buffer/client/cmd_buffer_helper.h	View	2 chunks	+1 line, -9 lines	0 comments	Download
M	gpu/command_buffer/client/cmd_buffer_helper.cc	View	3 chunks	+3 lines, -21 lines	0 comments	Download
M	gpu/command_buffer/client/cmd_buffer_helper_test.cc	View	2 chunks	+8 lines, -8 lines	0 comments	Download
M	gpu/command_buffer/client/fenced_allocator_test.cc	View	2 chunks	+8 lines, -8 lines	0 comments	Download
M	gpu/command_buffer/client/gles2_implementation_unittest.cc	View	39 chunks	+101 lines, -134 lines	0 comments	Download
M	gpu/command_buffer/client/mapped_memory_unittest.cc	View	2 chunks	+8 lines, -8 lines	0 comments	Download
M	gpu/command_buffer/client/ring_buffer_test.cc	View	2 chunks	+8 lines, -8 lines	0 comments	Download
M	gpu/command_buffer/common/command_buffer.h	View	2 chunks	+7 lines, -5 lines	0 comments	Download
M	gpu/command_buffer/common/command_buffer_mock.h	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	gpu/command_buffer/common/command_buffer_mock.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/service/cmd_buffer_engine.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	gpu/command_buffer/service/cmd_parser.h	View	2 chunks	+8 lines, -10 lines	0 comments	Download
M	gpu/command_buffer/service/cmd_parser.cc	View	1 chunk	+10 lines, -16 lines	0 comments	Download
M	gpu/command_buffer/service/cmd_parser_test.cc	View	2 chunks	+6 lines, -34 lines	0 comments	Download
M	gpu/command_buffer/service/command_buffer_service.h	View	2 chunks	+3 lines, -8 lines	0 comments	Download
M	gpu/command_buffer/service/command_buffer_service.cc	View	5 chunks	+57 lines, -30 lines	0 comments	Download
M	gpu/command_buffer/service/common_decoder_unittest.cc	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	gpu/command_buffer/service/gpu_scheduler.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	gpu/command_buffer/service/gpu_scheduler.cc	View	2 chunks	+15 lines, -20 lines	0 comments	Download
M	gpu/command_buffer/service/gpu_scheduler_unittest.cc	View	7 chunks	+19 lines, -30 lines	0 comments	Download
M	gpu/demos/framework/window.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/gles2_conform_support/egl/display.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/c/trusted/ppb_graphics_3d_trusted.h	View	1 chunk	+5 lines, -3 lines	0 comments	Download
M	ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_graphics_3d_rpc_server.cc	View	1 chunk	+20 lines, -6 lines	0 comments	Download
M	ppapi/native_client/src/shared/ppapi_proxy/command_buffer_nacl.h	View	1 chunk	+6 lines, -2 lines	0 comments	Download
M	ppapi/native_client/src/shared/ppapi_proxy/command_buffer_nacl.cc	View	2 chunks	+22 lines, -9 lines	0 comments	Download
M	ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_graphics_3d.cc	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	ppapi/native_client/src/shared/ppapi_proxy/ppb_graphics_3d.srpc	View	2 chunks	+8 lines, -7 lines	0 comments	Download
M	ppapi/native_client/src/shared/ppapi_proxy/ppb_rpc_client.cc	View	2 chunks	+9 lines, -5 lines	0 comments	Download
M	ppapi/native_client/src/shared/ppapi_proxy/ppb_rpc_server.cc	View	2 chunks	+7 lines, -6 lines	0 comments	Download
M	ppapi/native_client/src/shared/ppapi_proxy/trusted/srpcgen/ppb_rpc.h	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	ppapi/native_client/src/shared/ppapi_proxy/untrusted/srpcgen/ppb_rpc.h	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	ppapi/proxy/ppapi_messages.h	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	ppapi/proxy/ppb_graphics_3d_proxy.h	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	ppapi/proxy/ppb_graphics_3d_proxy.cc	View	8 chunks	+62 lines, -27 lines	0 comments	Download
M	ppapi/thunk/ppb_graphics_3d_api.h	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	ppapi/thunk/ppb_graphics_3d_trusted_thunk.cc	View	2 chunks	+7 lines, -5 lines	0 comments	Download
M	webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc	View	4 chunks	+1 line, -9 lines	0 comments	Download
M	webkit/plugins/ppapi/ppb_graphics_3d_impl.h	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	webkit/plugins/ppapi/ppb_graphics_3d_impl.cc	View	2 chunks	+7 lines, -6 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages