Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4326)

Unified Diff: chrome/browser/extensions/extension_tabs_module.cc

Issue 8863011: Panels back behind a flag. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix typo Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_tabs_module.cc
diff --git a/chrome/browser/extensions/extension_tabs_module.cc b/chrome/browser/extensions/extension_tabs_module.cc
index 71d3b83233ddd2b9e28e3c0de505a5170dbc1290..e7382a2882e05acfa649d2bf82db4117a504faa2 100644
--- a/chrome/browser/extensions/extension_tabs_module.cc
+++ b/chrome/browser/extensions/extension_tabs_module.cc
@@ -31,6 +31,7 @@
#include "chrome/browser/ui/browser_list.h"
#include "chrome/browser/ui/browser_navigator.h"
#include "chrome/browser/ui/browser_window.h"
+#include "chrome/browser/ui/panels/panel_manager.h"
#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"
#include "chrome/browser/ui/window_sizer.h"
#include "chrome/browser/web_applications/web_app.h"
@@ -461,13 +462,11 @@ bool CreateWindowFunction::RunImpl() {
window_type = Browser::TYPE_POPUP;
extension_id = GetExtension()->id();
} else if (type_str == keys::kWindowTypeValuePanel) {
- if (CommandLine::ForCurrentProcess()->HasSwitch(
- switches::kDisablePanels)) {
- window_type = Browser::TYPE_POPUP;
- } else {
- window_type = Browser::TYPE_PANEL;
- }
extension_id = GetExtension()->id();
+ if (PanelManager::ShouldUsePanels(extension_id))
+ window_type = Browser::TYPE_PANEL;
+ else
+ window_type = Browser::TYPE_POPUP;
} else if (type_str != keys::kWindowTypeValueNormal) {
error_ = keys::kInvalidWindowTypeError;
return false;

Powered by Google App Engine
This is Rietveld 408576698