Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Side by Side Diff: chrome/browser/extensions/extension_tabs_module.cc

Issue 8863011: Panels back behind a flag. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix typo Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/extension_tabs_module.h" 5 #include "chrome/browser/extensions/extension_tabs_module.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/base64.h" 10 #include "base/base64.h"
(...skipping 13 matching lines...) Expand all
24 #include "chrome/browser/net/url_fixer_upper.h" 24 #include "chrome/browser/net/url_fixer_upper.h"
25 #include "chrome/browser/prefs/incognito_mode_prefs.h" 25 #include "chrome/browser/prefs/incognito_mode_prefs.h"
26 #include "chrome/browser/profiles/profile.h" 26 #include "chrome/browser/profiles/profile.h"
27 #include "chrome/browser/sessions/restore_tab_helper.h" 27 #include "chrome/browser/sessions/restore_tab_helper.h"
28 #include "chrome/browser/tabs/tab_strip_model.h" 28 #include "chrome/browser/tabs/tab_strip_model.h"
29 #include "chrome/browser/translate/translate_tab_helper.h" 29 #include "chrome/browser/translate/translate_tab_helper.h"
30 #include "chrome/browser/ui/browser.h" 30 #include "chrome/browser/ui/browser.h"
31 #include "chrome/browser/ui/browser_list.h" 31 #include "chrome/browser/ui/browser_list.h"
32 #include "chrome/browser/ui/browser_navigator.h" 32 #include "chrome/browser/ui/browser_navigator.h"
33 #include "chrome/browser/ui/browser_window.h" 33 #include "chrome/browser/ui/browser_window.h"
34 #include "chrome/browser/ui/panels/panel_manager.h"
34 #include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h" 35 #include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"
35 #include "chrome/browser/ui/window_sizer.h" 36 #include "chrome/browser/ui/window_sizer.h"
36 #include "chrome/browser/web_applications/web_app.h" 37 #include "chrome/browser/web_applications/web_app.h"
37 #include "chrome/common/chrome_notification_types.h" 38 #include "chrome/common/chrome_notification_types.h"
38 #include "chrome/common/chrome_switches.h" 39 #include "chrome/common/chrome_switches.h"
39 #include "chrome/common/extensions/extension.h" 40 #include "chrome/common/extensions/extension.h"
40 #include "chrome/common/extensions/extension_error_utils.h" 41 #include "chrome/common/extensions/extension_error_utils.h"
41 #include "chrome/common/extensions/extension_messages.h" 42 #include "chrome/common/extensions/extension_messages.h"
42 #include "chrome/common/pref_names.h" 43 #include "chrome/common/pref_names.h"
43 #include "chrome/common/url_constants.h" 44 #include "chrome/common/url_constants.h"
(...skipping 410 matching lines...) Expand 10 before | Expand all | Expand 10 after
454 } 455 }
455 456
456 std::string type_str; 457 std::string type_str;
457 if (args->HasKey(keys::kWindowTypeKey)) { 458 if (args->HasKey(keys::kWindowTypeKey)) {
458 EXTENSION_FUNCTION_VALIDATE(args->GetString(keys::kWindowTypeKey, 459 EXTENSION_FUNCTION_VALIDATE(args->GetString(keys::kWindowTypeKey,
459 &type_str)); 460 &type_str));
460 if (type_str == keys::kWindowTypeValuePopup) { 461 if (type_str == keys::kWindowTypeValuePopup) {
461 window_type = Browser::TYPE_POPUP; 462 window_type = Browser::TYPE_POPUP;
462 extension_id = GetExtension()->id(); 463 extension_id = GetExtension()->id();
463 } else if (type_str == keys::kWindowTypeValuePanel) { 464 } else if (type_str == keys::kWindowTypeValuePanel) {
464 if (CommandLine::ForCurrentProcess()->HasSwitch( 465 extension_id = GetExtension()->id();
465 switches::kDisablePanels)) { 466 if (PanelManager::ShouldUsePanels(extension_id))
467 window_type = Browser::TYPE_PANEL;
468 else
466 window_type = Browser::TYPE_POPUP; 469 window_type = Browser::TYPE_POPUP;
467 } else {
468 window_type = Browser::TYPE_PANEL;
469 }
470 extension_id = GetExtension()->id();
471 } else if (type_str != keys::kWindowTypeValueNormal) { 470 } else if (type_str != keys::kWindowTypeValueNormal) {
472 error_ = keys::kInvalidWindowTypeError; 471 error_ = keys::kInvalidWindowTypeError;
473 return false; 472 return false;
474 } 473 }
475 } 474 }
476 } 475 }
477 476
478 // Unlike other window types, Panels do not take focus by default. 477 // Unlike other window types, Panels do not take focus by default.
479 if (!saw_focus_key && window_type == Browser::TYPE_PANEL) 478 if (!saw_focus_key && window_type == Browser::TYPE_PANEL)
480 focused = false; 479 focused = false;
(...skipping 1134 matching lines...) Expand 10 before | Expand all | Expand 10 after
1615 // called for every API call the extension made. 1614 // called for every API call the extension made.
1616 GotLanguage(language); 1615 GotLanguage(language);
1617 } 1616 }
1618 1617
1619 void DetectTabLanguageFunction::GotLanguage(const std::string& language) { 1618 void DetectTabLanguageFunction::GotLanguage(const std::string& language) {
1620 result_.reset(Value::CreateStringValue(language.c_str())); 1619 result_.reset(Value::CreateStringValue(language.c_str()));
1621 SendResponse(true); 1620 SendResponse(true);
1622 1621
1623 Release(); // Balanced in Run() 1622 Release(); // Balanced in Run()
1624 } 1623 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698