Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc

Issue 8863009: Fix alignment of avatar bubbles in the NTP (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: use Rect::Ofset() Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc b/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
index d367d50404b5b4645bc54c2df4ceb05144bf83ed..cc476a107aad480e85842d8bf47e9227ac8515a2 100644
--- a/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
+++ b/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
@@ -120,9 +120,11 @@ views::View* BookmarkBubbleView::GetInitiallyFocusedView() {
return title_tf_;
}
-gfx::Point BookmarkBubbleView::GetAnchorPoint() {
+gfx::Rect BookmarkBubbleView::GetAnchorRect() {
// Compensate for some built-in padding in the star image.
- return BubbleDelegateView::GetAnchorPoint().Subtract(gfx::Point(0, 5));
+ gfx::Rect rect(BubbleDelegateView::GetAnchorRect());
+ rect.Offset(0, -5);
msw 2011/12/08 00:40:14 Please change this to rect.Inset(5, 5); Thanks!
sail 2011/12/08 01:41:10 Unfortunately Inset() doesn't do the right thing s
msw 2011/12/08 06:26:41 Bummer! okay, I'll fix it later.
+ return rect;
}
void BookmarkBubbleView::WindowClosing() {

Powered by Google App Engine
This is Rietveld 408576698