Isolates generic DnsClient from AsyncHostResolver.

Isolates generic DnsClient from AsyncHostResolver. 

DnsClient provides a generic DNS client that allows fetching resource records. 
DnsClient is very lightweight and does not support aggregation, queuing or 
prioritization of requests. 

This is the first CL in a series to merge AsyncHostResolver into 
HostResolverImpl. 

Also introduces general-purpose BigEndianReader/Writer.

Removes DnsTransactionTest-related suppressions.

BUG=90881, 80225, 106688
TEST=./net_unittests


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113640

[szym, 2011-12-08 01:27:24]

All memory try bots seem happy.

mmenke: this is a merge of
http://codereview.chromium.org/8762001/
http://codereview.chromium.org/8837001/

timurrrr: PTAL removing test exclusions for DnsTransactionTest

In general, I believe that the memcheck failure was due to a bug in
MockClientSocketFactory, but I wasn't able to reproduce it. (I just get a DCHECK
failure.)

[mmenke, 2011-12-08 15:28:28]

On 2011/12/08 01:27:24, szym wrote:
> All memory try bots seem happy.
> 
> mmenke: this is a merge of
> http://codereview.chromium.org/8762001/
> http://codereview.chromium.org/8837001/
> 
> timurrrr: PTAL removing test exclusions for DnsTransactionTest
> 
> In general, I believe that the memcheck failure was due to a bug in
> MockClientSocketFactory, but I wasn't able to reproduce it. (I just get a
DCHECK
> failure.)

Just to be sure, this is purely a merge of the two earlier CLs (Other than the
exclusions, of course)?

[szym, 2011-12-08 15:32:40]

This is the exact merge + two line reorderings listed below + two exclusions.

http://codereview.chromium.org/8852009/diff/2001/net/dns/dns_transaction_unit...
File net/dns/dns_transaction_unittest.cc (right):

http://codereview.chromium.org/8852009/diff/2001/net/dns/dns_transaction_unit...
net/dns/dns_transaction_unittest.cc:33: callback_ =
base::Bind(&DnsTransactionTest::OnTransactionComplete,
Moved this statement here from the end of this function.

http://codereview.chromium.org/8852009/diff/2001/net/dns/dns_transaction_unit...
net/dns/dns_transaction_unittest.cc:83: DnsTransaction::ResultCallback
callback_;
Moved this member from the end of this group.

[mmenke, 2011-12-08 15:38:21]

Ok, net changes LGTM.

On 2011/12/08 15:32:40, szym wrote:
> This is the exact merge + two line reorderings listed below + two exclusions.
> 
>
http://codereview.chromium.org/8852009/diff/2001/net/dns/dns_transaction_unit...
> File net/dns/dns_transaction_unittest.cc (right):
> 
>
http://codereview.chromium.org/8852009/diff/2001/net/dns/dns_transaction_unit...
> net/dns/dns_transaction_unittest.cc:33: callback_ =
> base::Bind(&DnsTransactionTest::OnTransactionComplete,
> Moved this statement here from the end of this function.
> 
>
http://codereview.chromium.org/8852009/diff/2001/net/dns/dns_transaction_unit...
> net/dns/dns_transaction_unittest.cc:83: DnsTransaction::ResultCallback
> callback_;
> Moved this member from the end of this group.

[Timur Iskhodzhanov, 2011-12-08 17:09:05]

Exclusions don't need LGTM if you've made sure everything works :)

On 2011/12/08 15:38:21, Matt Menke wrote:
> Ok, net changes LGTM.
> 
> On 2011/12/08 15:32:40, szym wrote:
> > This is the exact merge + two line reorderings listed below + two
exclusions.
> > 
> >
>
http://codereview.chromium.org/8852009/diff/2001/net/dns/dns_transaction_unit...
> > File net/dns/dns_transaction_unittest.cc (right):
> > 
> >
>
http://codereview.chromium.org/8852009/diff/2001/net/dns/dns_transaction_unit...
> > net/dns/dns_transaction_unittest.cc:33: callback_ =
> > base::Bind(&DnsTransactionTest::OnTransactionComplete,
> > Moved this statement here from the end of this function.
> > 
> >
>
http://codereview.chromium.org/8852009/diff/2001/net/dns/dns_transaction_unit...
> > net/dns/dns_transaction_unittest.cc:83: DnsTransaction::ResultCallback
> > callback_;
> > Moved this member from the end of this group.

[szym, 2011-12-08 17:11:08]

On 2011/12/08 17:09:05, Timur Iskhodzhanov wrote:
> Exclusions don't need LGTM if you've made sure everything works :)

Alright, thanks!

[commit-bot: I haz the power, 2011-12-08 17:27:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/szym@chromium.org/8852009/2001

[commit-bot: I haz the power, 2011-12-08 17:27:43]

Can't process patch for file net/dns/dns_client.h.
File's status is None, patchset upload is incomplete.

[commit-bot: I haz the power, 2011-12-08 18:23:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/szym@chromium.org/8852009/8003

[commit-bot: I haz the power, 2011-12-08 19:29:17]

Change committed as 113640