Issue 8837001: Adjust timeouts on DnsTransactionTest for valgrind

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8837001: Adjust timeouts on DnsTransactionTest for valgrind (Closed)

Created:
9 years ago by szym

Modified:
9 years ago

Reviewers:
cbentzel, mmenke

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, mmenke, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Adjust timeouts on DnsTransactionTest for valgrind TEST=tools/valgrind/chrome_tests.sh -t net --gtest_filter=DnsTrans*

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -7 lines)			Patch
	M	net/dns/dns_transaction_unittest.cc	View		5 chunks	+21 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

szym

Passed on try bots: http://build.chromium.org/p/tryserver.chromium/builders/linux_valgrind/builds/335 http://build.chromium.org/p/tryserver.chromium/builders/linux_chromeos_valgrind/builds/61

9 years ago (2011-12-07 04:33:25 UTC) #1

szym

Meant: http://build.chromium.org/p/tryserver.chromium/builders/linux_valgrind/builds/336 http://build.chromium.org/p/tryserver.chromium/builders/linux_chromeos_valgrind/builds/62

9 years ago (2011-12-07 15:49:11 UTC) #2

mmenke

LGTM as-is, but is there any reason not to always just use TestTimeouts::tiny_timeout_ms()?

9 years ago (2011-12-07 15:53:13 UTC) #3

szym

9 years ago (2011-12-07 15:57:52 UTC) #4

On 2011/12/07 15:53:13, Matt Menke wrote:
> LGTM as-is, but is there any reason not to always just use
> TestTimeouts::tiny_timeout_ms()?

I wanted to make sure NormalQueryResponseTest does not time out, although if it
timed out with tiny_timeout_ms then the XXXTimeoutTest(s) would fail too. That
said, I'd rather have one flaky test than all of them.

Thanks for review, although this CL cannot land anyway as the original was
reverted. I'll see if the bots are happy with tiny_timeout_ms throughout.

Expand Messages | Collapse Messages