[Sync] Replace all instances of ModelTypeSet with ModelEnumSet

[Sync] Replace all instances of ModelTypeSet with ModelEnumSet

Also change some functions to return ModelEnumSets directly instead of
taking a pointer value.

BUG=79970
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113906

[akalin, 2011-12-07 18:47:04]

+zea for review

Some things to watch out for:
- A common error I made was replacing foo.count(x) == 0 with foo.Has(x) instead
of !foo.has(x).
- Having ModelTypeSet in EXPECT_CALLs should be now replaced with
HasModelTypes(enum_set).  I temporarily replaced them with _.

I'm pretty sure I got all of the cases above, but a second pair of eyes won't
hurt.

[Nicolas Zea, 2011-12-08 01:49:36]

LGTM with nits and assuming those trybot failures are unrelated (they look
suspicious)

http://codereview.chromium.org/8851006/diff/3001/chrome/browser/sync/engine/a...
File chrome/browser/sync/engine/apply_updates_command_unittest.cc (right):

http://codereview.chromium.org/8851006/diff/3001/chrome/browser/sync/engine/a...
chrome/browser/sync/engine/apply_updates_command_unittest.cc:472: EXPECT_TRUE(
ExpectTrue(cryptographer->GetEncryptedTypes()
                      .Equals(syncable::ModelEnumSet::All()));

http://codereview.chromium.org/8851006/diff/3001/chrome/browser/sync/engine/s...
File chrome/browser/sync/engine/syncer_proto_util.cc (right):

http://codereview.chromium.org/8851006/diff/3001/chrome/browser/sync/engine/s...
chrome/browser/sync/engine/syncer_proto_util.cc:197: if
(error.error_data_types.Size() > 0) {
!Empty()

http://codereview.chromium.org/8851006/diff/3001/chrome/browser/sync/glue/dat...
File chrome/browser/sync/glue/data_type_manager_impl.cc (right):

http://codereview.chromium.org/8851006/diff/3001/chrome/browser/sync/glue/dat...
chrome/browser/sync/glue/data_type_manager_impl.cc:103:
DataTypeController::TypeMap::const_iterator dtc = controllers_->find(it.Get());
longer 80 chars?

http://codereview.chromium.org/8851006/diff/3001/chrome/browser/sync/internal...
File chrome/browser/sync/internal_api/syncapi_unittest.cc (right):

http://codereview.chromium.org/8851006/diff/3001/chrome/browser/sync/internal...
chrome/browser/sync/internal_api/syncapi_unittest.cc:1314:
EXPECT_TRUE(GetEncryptedTypes(&trans)
make consistent with below lines

http://codereview.chromium.org/8851006/diff/3001/chrome/browser/sync/profile_...
File chrome/browser/sync/profile_sync_service_harness.cc (right):

http://codereview.chromium.org/8851006/diff/3001/chrome/browser/sync/profile_...
chrome/browser/sync/profile_sync_service_harness.cc:459:
GetPendingMigrationTypesForTest());
indent by four more spaces

http://codereview.chromium.org/8851006/diff/3001/chrome/browser/sync/util/cry...
File chrome/browser/sync/util/cryptographer_unittest.cc (right):

http://codereview.chromium.org/8851006/diff/3001/chrome/browser/sync/util/cry...
chrome/browser/sync/util/cryptographer_unittest.cc:226:
OnEncryptedTypesChanged(_,
modelenumset::all?

[akalin, 2011-12-09 19:10:09]

Committing after tests pass

http://codereview.chromium.org/8851006/diff/3001/chrome/browser/sync/engine/a...
File chrome/browser/sync/engine/apply_updates_command_unittest.cc (right):

http://codereview.chromium.org/8851006/diff/3001/chrome/browser/sync/engine/a...
chrome/browser/sync/engine/apply_updates_command_unittest.cc:472: EXPECT_TRUE(
On 2011/12/08 01:49:37, nzea wrote:
> ExpectTrue(cryptographer->GetEncryptedTypes()
>                       .Equals(syncable::ModelEnumSet::All()));

Indented 4 spaces instead

http://codereview.chromium.org/8851006/diff/3001/chrome/browser/sync/engine/s...
File chrome/browser/sync/engine/syncer_proto_util.cc (right):

http://codereview.chromium.org/8851006/diff/3001/chrome/browser/sync/engine/s...
chrome/browser/sync/engine/syncer_proto_util.cc:197: if
(error.error_data_types.Size() > 0) {
On 2011/12/08 01:49:37, nzea wrote:
> !Empty()

Done.

http://codereview.chromium.org/8851006/diff/3001/chrome/browser/sync/glue/dat...
File chrome/browser/sync/glue/data_type_manager_impl.cc (right):

http://codereview.chromium.org/8851006/diff/3001/chrome/browser/sync/glue/dat...
chrome/browser/sync/glue/data_type_manager_impl.cc:103:
DataTypeController::TypeMap::const_iterator dtc = controllers_->find(it.Get());
On 2011/12/08 01:49:37, nzea wrote:
> longer 80 chars?

Done.

http://codereview.chromium.org/8851006/diff/3001/chrome/browser/sync/internal...
File chrome/browser/sync/internal_api/syncapi_unittest.cc (right):

http://codereview.chromium.org/8851006/diff/3001/chrome/browser/sync/internal...
chrome/browser/sync/internal_api/syncapi_unittest.cc:1314:
EXPECT_TRUE(GetEncryptedTypes(&trans)
On 2011/12/08 01:49:37, nzea wrote:
> make consistent with below lines

Done.

http://codereview.chromium.org/8851006/diff/3001/chrome/browser/sync/profile_...
File chrome/browser/sync/profile_sync_service_harness.cc (right):

http://codereview.chromium.org/8851006/diff/3001/chrome/browser/sync/profile_...
chrome/browser/sync/profile_sync_service_harness.cc:459:
GetPendingMigrationTypesForTest());
On 2011/12/08 01:49:37, nzea wrote:
> indent by four more spaces

Done.

http://codereview.chromium.org/8851006/diff/3001/chrome/browser/sync/util/cry...
File chrome/browser/sync/util/cryptographer_unittest.cc (right):

http://codereview.chromium.org/8851006/diff/3001/chrome/browser/sync/util/cry...
chrome/browser/sync/util/cryptographer_unittest.cc:226:
OnEncryptedTypesChanged(_,
On 2011/12/08 01:49:37, nzea wrote:
> modelenumset::all?

Done.

[commit-bot: I haz the power, 2011-12-09 23:07:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/akalin@chromium.org/8851006/17003

[commit-bot: I haz the power, 2011-12-10 01:00:56]

Change committed as 113906