Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1930)

Unified Diff: chrome/browser/sync/test/integration/enable_disable_test.cc

Issue 8851006: [Sync] Replace all instances of ModelTypeSet with ModelEnumSet (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Cleanup pass #2 Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/test/integration/enable_disable_test.cc
diff --git a/chrome/browser/sync/test/integration/enable_disable_test.cc b/chrome/browser/sync/test/integration/enable_disable_test.cc
index fd4363ddcfb45dbc4308a171dd15bf48ed4b6a35..7acbfb67fa659c6a98da9c0093a860706395116e 100644
--- a/chrome/browser/sync/test/integration/enable_disable_test.cc
+++ b/chrome/browser/sync/test/integration/enable_disable_test.cc
@@ -43,25 +43,25 @@ IN_PROC_BROWSER_TEST_F(EnableDisableSingleClientTest, EnableOneAtATime) {
DisableNotifications();
// Setup sync with no enabled types.
- ASSERT_TRUE(GetClient(0)->SetupSync(syncable::ModelTypeSet()));
+ ASSERT_TRUE(GetClient(0)->SetupSync(syncable::ModelEnumSet()));
- syncable::ModelTypeSet registered_types;
- GetClient(0)->service()->GetRegisteredDataTypes(&registered_types);
+ const syncable::ModelEnumSet registered_types =
+ GetClient(0)->service()->GetRegisteredDataTypes();
sync_api::UserShare* user_share = GetClient(0)->service()->GetUserShare();
- for (syncable::ModelTypeSet::const_iterator it = registered_types.begin();
- it != registered_types.end(); ++it) {
- ASSERT_TRUE(GetClient(0)->EnableSyncForDatatype(*it));
+ for (syncable::ModelEnumSet::Iterator it = registered_types.First();
+ it.Good(); it.Inc()) {
+ ASSERT_TRUE(GetClient(0)->EnableSyncForDatatype(it.Get()));
// AUTOFILL_PROFILE is lumped together with AUTOFILL.
- if (*it == syncable::AUTOFILL_PROFILE) {
+ if (it.Get() == syncable::AUTOFILL_PROFILE) {
continue;
}
- ASSERT_TRUE(DoesTopLevelNodeExist(user_share, *it))
- << syncable::ModelTypeToString(*it);
+ ASSERT_TRUE(DoesTopLevelNodeExist(user_share, it.Get()))
+ << syncable::ModelTypeToString(it.Get());
// AUTOFILL_PROFILE is lumped together with AUTOFILL.
- if (*it == syncable::AUTOFILL) {
+ if (it.Get() == syncable::AUTOFILL) {
ASSERT_TRUE(DoesTopLevelNodeExist(user_share,
syncable::AUTOFILL_PROFILE));
}
@@ -78,34 +78,34 @@ IN_PROC_BROWSER_TEST_F(EnableDisableSingleClientTest, DisableOneAtATime) {
// Setup sync with no disabled types.
ASSERT_TRUE(GetClient(0)->SetupSync());
- syncable::ModelTypeSet registered_types;
- GetClient(0)->service()->GetRegisteredDataTypes(&registered_types);
+ const syncable::ModelEnumSet registered_types =
+ GetClient(0)->service()->GetRegisteredDataTypes();
sync_api::UserShare* user_share = GetClient(0)->service()->GetUserShare();
// Make sure all top-level nodes exist first.
- for (syncable::ModelTypeSet::const_iterator it = registered_types.begin();
- it != registered_types.end(); ++it) {
- ASSERT_TRUE(DoesTopLevelNodeExist(user_share, *it));
+ for (syncable::ModelEnumSet::Iterator it = registered_types.First();
+ it.Good(); it.Inc()) {
+ ASSERT_TRUE(DoesTopLevelNodeExist(user_share, it.Get()));
}
- for (syncable::ModelTypeSet::const_iterator it = registered_types.begin();
- it != registered_types.end(); ++it) {
- ASSERT_TRUE(GetClient(0)->DisableSyncForDatatype(*it));
+ for (syncable::ModelEnumSet::Iterator it = registered_types.First();
+ it.Good(); it.Inc()) {
+ ASSERT_TRUE(GetClient(0)->DisableSyncForDatatype(it.Get()));
// AUTOFILL_PROFILE is lumped together with AUTOFILL.
- if (*it == syncable::AUTOFILL_PROFILE) {
+ if (it.Get() == syncable::AUTOFILL_PROFILE) {
continue;
}
sync_api::UserShare* user_share =
GetClient(0)->service()->GetUserShare();
- ASSERT_FALSE(DoesTopLevelNodeExist(user_share, *it))
- << syncable::ModelTypeToString(*it);
+ ASSERT_FALSE(DoesTopLevelNodeExist(user_share, it.Get()))
+ << syncable::ModelTypeToString(it.Get());
// AUTOFILL_PROFILE is lumped together with AUTOFILL.
- if (*it == syncable::AUTOFILL) {
+ if (it.Get() == syncable::AUTOFILL) {
ASSERT_FALSE(DoesTopLevelNodeExist(user_share,
syncable::AUTOFILL_PROFILE));
}
« no previous file with comments | « chrome/browser/sync/syncable/model_type_unittest.cc ('k') | chrome/browser/sync/test/integration/migration_errors_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698