Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8851004: [Sync] Replace all instances of ModelTypeBitSet with ModelEnumSet (Closed)

Created:
9 years ago by akalin
Modified:
9 years ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, Raghu Simha, ncarter (slow), akalin, tim (not reviewing), Paweł Hajdan Jr.
Visibility:
Public.

Description

[Sync] Replace all instances of ModelTypeBitSet with ModelEnumSet Also introduce FullModelEnumSet for use cases that work with UNSPECIFIED and TOP_LEVEL_FOLDER types. Remove all functions that work with ModelTypeBitSet. BUG=79970 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113639

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -217 lines) Patch
M chrome/browser/sync/engine/apply_updates_command.cc View 3 chunks +12 lines, -16 lines 0 comments Download
M chrome/browser/sync/engine/store_timestamps_command.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/sync/engine/sync_scheduler.cc View 5 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/sync/engine/sync_scheduler_unittest.cc View 18 chunks +19 lines, -19 lines 0 comments Download
M chrome/browser/sync/engine/syncer_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/sync_backend_host.cc View 2 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/sync/internal_api/sync_manager.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/internal_api/sync_manager.cc View 17 chunks +19 lines, -21 lines 0 comments Download
M chrome/browser/sync/profile_sync_service.cc View 1 chunk +7 lines, -5 lines 0 comments Download
M chrome/browser/sync/sync_prefs.cc View 1 chunk +14 lines, -14 lines 0 comments Download
M chrome/browser/sync/syncable/model_type.h View 3 chunks +2 lines, -17 lines 0 comments Download
M chrome/browser/sync/syncable/model_type.cc View 4 chunks +0 lines, -62 lines 0 comments Download
M chrome/browser/sync/syncable/model_type_unittest.cc View 1 chunk +0 lines, -27 lines 0 comments Download
M chrome/browser/sync/syncable/syncable.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/syncable/syncable.cc View 2 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/sync/syncable/syncable_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
akalin
+zea for review
9 years ago (2011-12-07 17:55:19 UTC) #1
Nicolas Zea
LGTM!
9 years ago (2011-12-08 01:02:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/8851004/1
9 years ago (2011-12-08 18:13:46 UTC) #3
commit-bot: I haz the power
9 years ago (2011-12-08 19:26:13 UTC) #4 
Change committed as 113639

Powered by Google App Engine
This is Rietveld 408576698