Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Unified Diff: chrome/browser/sync/syncable/model_type_unittest.cc

Issue 8851004: [Sync] Replace all instances of ModelTypeBitSet with ModelEnumSet (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/syncable/model_type.cc ('k') | chrome/browser/sync/syncable/syncable.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/syncable/model_type_unittest.cc
diff --git a/chrome/browser/sync/syncable/model_type_unittest.cc b/chrome/browser/sync/syncable/model_type_unittest.cc
index 5b39a3cb2995a348f0210782ca102534122f4cec..2db0ab91e7be1506ed1cb3ad8602a292ce274a3c 100644
--- a/chrome/browser/sync/syncable/model_type_unittest.cc
+++ b/chrome/browser/sync/syncable/model_type_unittest.cc
@@ -38,33 +38,6 @@ TEST_F(ModelTypeTest, ModelTypeFromValue) {
}
}
-TEST_F(ModelTypeTest, ModelTypeBitSetToValue) {
- ModelTypeBitSet model_types;
- model_types.set(syncable::BOOKMARKS);
- model_types.set(syncable::APPS);
-
- scoped_ptr<ListValue> value(ModelTypeBitSetToValue(model_types));
- EXPECT_EQ(2u, value->GetSize());
- std::string types[2];
- EXPECT_TRUE(value->GetString(0, &types[0]));
- EXPECT_TRUE(value->GetString(1, &types[1]));
- EXPECT_EQ("Bookmarks", types[0]);
- EXPECT_EQ("Apps", types[1]);
-}
-
-TEST_F(ModelTypeTest, ModelTypeBitSetFromValue) {
- // Try empty set first.
- ModelTypeBitSet model_types;
- scoped_ptr<ListValue> value(ModelTypeBitSetToValue(model_types));
- EXPECT_EQ(model_types, ModelTypeBitSetFromValue(*value));
-
- // Now try with a few random types.
- model_types.set(syncable::BOOKMARKS);
- model_types.set(syncable::APPS);
- value.reset(ModelTypeBitSetToValue(model_types));
- EXPECT_EQ(model_types, ModelTypeBitSetFromValue(*value));
-}
-
TEST_F(ModelTypeTest, ModelTypeSetToValue) {
ModelTypeSet model_types;
model_types.insert(syncable::BOOKMARKS);
« no previous file with comments | « chrome/browser/sync/syncable/model_type.cc ('k') | chrome/browser/sync/syncable/syncable.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698