Add a context field to the accessibility extension API.

chrome/browser/accessibility/accessibility_events.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_ACCESSIBILITY_ACCESSIBILITY_EVENTS_H_
 #define CHROME_BROWSER_ACCESSIBILITY_ACCESSIBILITY_EVENTS_H_
 #pragma once
 
 #include <string>
 #include "base/compiler_specific.h"
@@ skipping 41 matching lines @@
   // Serialize this class as a DictionaryValue that can be converted to
   // a JavaScript object.
   virtual void SerializeToDict(base::DictionaryValue* dict) const OVERRIDE;
 
   // Return the specific type of this control, which will be one of the
   // string constants defined in extension_accessibility_api_constants.h.
   virtual const char* type() const = 0;
 
   const std::string& name() const { return name_; }
 
+  const std::string& context() const { return context_; }
+  void set_context(const std::string& context) { context_ = context; }

[hashimoto, 2011/12/07 23:07:35]

Instead of exposing the setter, how about setting |context_| by ctors?
It will be more consistent with |name_|

[dmazzoni, 2011/12/07 23:34:12]

Sure, I changed it to be in the constructor.

Now there are a couple of subclasses where a context probably isn't needed, so
the subclass passes std::string(), does that seem reasonable?

[hashimoto, 2011/12/08 00:04:13]

How about having two ctors (two argument version and three argument version) ?
Or having single two-argument ctor while having set_context as a protected
method and using it to set |context| in subclasses' ctors.

+
  protected:
   AccessibilityControlInfo(Profile* profile, const std::string& control_name);
 
   // The name of the control, like "OK" or "Password".
   std::string name_;
+
+  // A string describing the context of the control, such as the name of
+  // the group or toolbar it's contained in.
+  std::string context_;
 };
 
 // Accessibility information about a window passed to onWindowOpened
 // and onWindowClosed event listeners.
 class AccessibilityWindowInfo : public AccessibilityControlInfo {
  public:
   AccessibilityWindowInfo(Profile* profile, const std::string& window_name);
 
   virtual const char* type() const OVERRIDE;
 };
@@ skipping 241 matching lines @@
   bool has_submenu() const { return has_submenu_; }
 
  private:
   bool has_submenu_;
   // The 0-based index of the current item and the number of total items.
   int item_index_;
   int item_count_;
 };
 
 #endif  // CHROME_BROWSER_ACCESSIBILITY_ACCESSIBILITY_EVENTS_H_