Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4388)

Unified Diff: chrome/browser/accessibility/accessibility_events.h

Issue 8850004: Add a context field to the accessibility extension API. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/accessibility/accessibility_events.h
===================================================================
--- chrome/browser/accessibility/accessibility_events.h (revision 112880)
+++ chrome/browser/accessibility/accessibility_events.h (working copy)
@@ -59,11 +59,18 @@
const std::string& name() const { return name_; }
+ const std::string& context() const { return context_; }
+ void set_context(const std::string& context) { context_ = context; }
hashimoto 2011/12/07 23:07:35 Instead of exposing the setter, how about setting
dmazzoni 2011/12/07 23:34:12 Sure, I changed it to be in the constructor. Now
hashimoto 2011/12/08 00:04:13 How about having two ctors (two argument version a
+
protected:
AccessibilityControlInfo(Profile* profile, const std::string& control_name);
// The name of the control, like "OK" or "Password".
std::string name_;
+
+ // A string describing the context of the control, such as the name of
+ // the group or toolbar it's contained in.
+ std::string context_;
};
// Accessibility information about a window passed to onWindowOpened

Powered by Google App Engine
This is Rietveld 408576698