Send a11y events from NativeTextfieldViews when the state changes.

Send a11y events from NativeTextfieldViews when the state changes.

BUG=106716
TEST=On Chrome OS, manually test typing and autocompleting in the omnibox with accessibility turned on.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113427

[sky, 2011-12-07 17:10:00]

http://codereview.chromium.org/8850001/diff/1/ui/views/controls/textfield/nat...
File ui/views/controls/textfield/native_textfield_views.cc (right):

http://codereview.chromium.org/8850001/diff/1/ui/views/controls/textfield/nat...
ui/views/controls/textfield/native_textfield_views.cc:461:
textfield_->GetWidget()->NotifyAccessibilityEvent(
I'm not familiar with EVENT_TEXT_CHANGED. Should it be sent when only the
selection changes?

[dmazzoni, 2011-12-07 17:25:35]

http://codereview.chromium.org/8850001/diff/1/ui/views/controls/textfield/nat...
File ui/views/controls/textfield/native_textfield_views.cc (right):

http://codereview.chromium.org/8850001/diff/1/ui/views/controls/textfield/nat...
ui/views/controls/textfield/native_textfield_views.cc:461:
textfield_->GetWidget()->NotifyAccessibilityEvent(
On 2011/12/07 17:10:01, sky wrote:
> I'm not familiar with EVENT_TEXT_CHANGED. Should it be sent when only the
> selection changes?

TEXT_CHANGED implies SELECTION_CHANGED, but you're right, it'd be better to use
SELECTION_CHANGED if that's all that changed.

I modified the logic to send the appropriate event. Sometimes now both will get
fired (like during an autocomplete), but there's no harm in that, the assistive
technology will ignore the second notification.

[sky, 2011-12-07 17:27:48]

LGTM

[commit-bot: I haz the power, 2011-12-07 17:28:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/8850001/5001

[commit-bot: I haz the power, 2011-12-07 18:56:53]

Change committed as 113427