Send a11y events from NativeTextfieldViews when the state changes.

ui/views/controls/textfield/native_textfield_views.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/textfield/native_textfield_views.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/command_line.h"
@@ skipping 440 matching lines @@
 }
 
 void NativeTextfieldViews::GetSelectedRange(ui::Range* range) const {
   model_->GetSelectedRange(range);
 }
 
 void NativeTextfieldViews::SelectRange(const ui::Range& range) {
   model_->SelectRange(range);
   OnCaretBoundsChanged();
   SchedulePaint();
+  textfield_->GetWidget()->NotifyAccessibilityEvent(

[sky, 2011/12/07 17:10:01]

I'm not familiar with EVENT_TEXT_CHANGED. Should it be sent when only the
selection changes?

[dmazzoni, 2011/12/07 17:25:35]

TEXT_CHANGED implies SELECTION_CHANGED, but you're right, it'd be better to use
SELECTION_CHANGED if that's all that changed.

I modified the logic to send the appropriate event. Sometimes now both will get
fired (like during an autocomplete), but there's no harm in that, the assistive
technology will ignore the second notification.

+      textfield_, ui::AccessibilityTypes::EVENT_TEXT_CHANGED, true);
 }
 
 void NativeTextfieldViews::GetSelectionModel(gfx::SelectionModel* sel) const {
   model_->GetSelectionModel(sel);
 }
 
 void NativeTextfieldViews::SelectSelectionModel(
     const gfx::SelectionModel& sel) {
   model_->SelectSelectionModel(sel);
   OnCaretBoundsChanged();
@@ skipping 468 matching lines @@
                                              bool cursor_changed) {
   if (text_changed)
     PropagateTextChange();
   if (cursor_changed) {
     is_cursor_visible_ = true;
     RepaintCursor();
   }
   if (text_changed || cursor_changed) {
     OnCaretBoundsChanged();
     SchedulePaint();
+    textfield_->GetWidget()->NotifyAccessibilityEvent(
+        textfield_, ui::AccessibilityTypes::EVENT_TEXT_CHANGED, true);
   }
 }
 
 void NativeTextfieldViews::UpdateContextMenu() {
   if (!context_menu_contents_.get()) {
     context_menu_contents_.reset(new ui::SimpleMenuModel(this));
     context_menu_contents_->AddItemWithStringId(IDS_APP_CUT, IDS_APP_CUT);
     context_menu_contents_->AddItemWithStringId(IDS_APP_COPY, IDS_APP_COPY);
     context_menu_contents_->AddItemWithStringId(IDS_APP_PASTE, IDS_APP_PASTE);
     context_menu_contents_->AddItemWithStringId(IDS_APP_DELETE, IDS_APP_DELETE);
@@ skipping 117 matching lines @@
 
 #if defined(USE_AURA)
 // static
 NativeTextfieldWrapper* NativeTextfieldWrapper::CreateWrapper(
     Textfield* field) {
   return new NativeTextfieldViews(field);
 }
 #endif
 
 }  // namespace views