Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Issue 8847005: Add decorations to bot names for modifying parts of try sets. (Closed)

Created:
9 years ago by Peter Mayo
Modified:
9 years ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, cmp, Nicolas Sylvain
Visibility:
Public.

Description

Add decorations to bot names for modifying parts of try sets. BUG=None TEST=New jobs supported. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114145

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 11

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Total comments: 18

Patch Set 6 : '' #

Patch Set 7 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -9 lines) Patch
M scripts/master/try_job_base.py View 1 2 3 4 5 6 1 chunk +18 lines, -0 lines 0 comments Download
M scripts/master/try_job_base_bb7.py View 1 2 3 4 5 6 1 chunk +3 lines, -2 lines 0 comments Download
M scripts/master/try_job_base_bb8.py View 1 2 3 4 5 6 2 chunks +12 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Peter Mayo
Self-review. http://codereview.chromium.org/8847005/diff/2001/masters/master.tryserver.chromium/master.cfg File masters/master.tryserver.chromium/master.cfg (right): http://codereview.chromium.org/8847005/diff/2001/masters/master.tryserver.chromium/master.cfg#newcode29 masters/master.tryserver.chromium/master.cfg:29: LISTEN_TO_SVN = True Testing: remove http://codereview.chromium.org/8847005/diff/2001/scripts/master/try_job_base.py File scripts/master/try_job_base.py ...
9 years ago (2011-12-07 16:38:00 UTC) #1
Peter Mayo
Some rework still retesting, but I think this is good to look at now. http://codereview.chromium.org/8847005/diff/2001/masters/master.tryserver.chromium/master.cfg ...
9 years ago (2011-12-09 21:29:08 UTC) #2
M-A Ruel
http://codereview.chromium.org/8847005/diff/2001/masters/master.tryserver.chromium/master.cfg File masters/master.tryserver.chromium/master.cfg (right): http://codereview.chromium.org/8847005/diff/2001/masters/master.tryserver.chromium/master.cfg#newcode29 masters/master.tryserver.chromium/master.cfg:29: LISTEN_TO_SVN = True On 2011/12/07 16:38:00, Peter Mayo wrote: ...
9 years ago (2011-12-09 21:50:29 UTC) #3
Peter Mayo
http://codereview.chromium.org/8847005/diff/5009/scripts/master/try_job_base.py File scripts/master/try_job_base.py (right): http://codereview.chromium.org/8847005/diff/5009/scripts/master/try_job_base.py#newcode75 scripts/master/try_job_base.py:75: build_names = [] On 2011/12/09 21:50:29, Marc-Antoine Ruel wrote: ...
9 years ago (2011-12-10 01:08:26 UTC) #4
M-A Ruel
http://codereview.chromium.org/8847005/diff/5009/scripts/master/try_job_base.py File scripts/master/try_job_base.py (right): http://codereview.chromium.org/8847005/diff/5009/scripts/master/try_job_base.py#newcode75 scripts/master/try_job_base.py:75: build_names = [] Personally, I wouldn't touch this file ...
9 years ago (2011-12-12 20:46:58 UTC) #5
Peter Mayo
On 2011/12/12 20:46:58, Marc-Antoine Ruel wrote: > File scripts/master/try_job_base.py (right): > ... > Personally, I ...
9 years ago (2011-12-12 21:55:56 UTC) #6
M-A Ruel
On 2011/12/12 21:55:56, Peter Mayo wrote: > I presume the previous comment is scoped to ...
9 years ago (2011-12-12 22:32:44 UTC) #7
Peter Mayo
Retested: Started submitted jobs with and without decoration.
9 years ago (2011-12-13 00:17:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/petermayo@chromium.org/8847005/14001
9 years ago (2011-12-13 00:17:14 UTC) #9
commit-bot: I haz the power
Presubmit check for 8847005-14001 failed and returned exit status 1. Running presubmit commit checks ...
9 years ago (2011-12-13 00:19:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/petermayo@chromium.org/8847005/14001
9 years ago (2011-12-13 01:40:49 UTC) #11
commit-bot: I haz the power
9 years ago (2011-12-13 01:42:49 UTC) #12
Change committed as 114145

Powered by Google App Engine
This is Rietveld 408576698