Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Unified Diff: scripts/master/try_job_base.py

Issue 8847005: Add decorations to bot names for modifying parts of try sets. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build/
Patch Set: '' Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/master/try_job_base_bb7.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/master/try_job_base.py
===================================================================
--- scripts/master/try_job_base.py (revision 114099)
+++ scripts/master/try_job_base.py (working copy)
@@ -92,3 +92,21 @@
props.updateFromProperties(self.properties)
props.update(properties, 'Try job')
return props
+
+ # R0201: 96,0:TryJobBase.parse_decoration: Method could be a function
+ # No, this would disturb the finding of it from the MixIn classes.
+ # pylint: disable=R0201
+ def parse_decoration(self, properties, decorations):
+ """Returns properties extended by the meaning of decoration.
+ """
+
+ props = Properties()
+ props.updateFromProperties(properties)
+ for decoration in decorations.split(':'):
+ if decoration == 'compile':
+ testfilter = props.getProperty('testfilter') or 'None'
+ props.setProperty('testfilter', testfilter, 'Decoration')
+
+ #TODO(petermayo) Define a DSL of useful modifications to individual
+ # bots of a test run.
+ return props
« no previous file with comments | « no previous file | scripts/master/try_job_base_bb7.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698