Make callback.h include callback_forward.h and add comments about forward declaration.

Make callback.h include callback_forward.h and add comments about forward declaration.

The first bit is designed to ensure that the correctness of callback_forward.h is tested by the callback unittests. The second bit is designed to increase the likelihood of developers actually using callback_forward.h as intended.

BUG=None
TEST=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113472

[erikwright (departed), 2011-12-07 16:24:10]

Hi William,

PTAL. I'm very open to moving the comments about or adjusting the language as
you see appropriate.

Thanks,

Erik

[willchan no longer on Chromium, 2011-12-07 16:25:34]

LGTM, but please wait for ajwong's review.

[erikwright (departed), 2011-12-07 16:26:35]

On 2011/12/07 16:25:34, willchan wrote:
> LGTM, but please wait for ajwong's review.

Sorry, I don't know why, in my head, you are the callback guy.

[willchan no longer on Chromium, 2011-12-07 16:30:34]

Hehe, ajwong is definitely the callback guy. I'm just the rubberstamper and
receiver of painful code reviews :)

On Wed, Dec 7, 2011 at 8:26 AM, <erikwright@chromium.org> wrote:

> On 2011/12/07 16:25:34, willchan wrote:
>
>> LGTM, but please wait for ajwong's review.
>>
>
> Sorry, I don't know why, in my head, you are the callback guy.
>
>
http://codereview.chromium.**org/8846003/<http://codereview.chromium.org/8846...
>

[awong, 2011-12-07 18:41:20]

LGTM

@willchan: there's a correlation between good reviewers and getting hard
reviews. :)

[awong, 2011-12-07 18:41:56]

oh, please fix up the BUG and TEST lines before committing.

On 2011/12/07 18:41:20, awong wrote:
> LGTM
> 
> @willchan: there's a correlation between good reviewers and getting hard
> reviews. :)

[commit-bot: I haz the power, 2011-12-07 18:51:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erikwright@chromium.org/8846003/1

[commit-bot: I haz the power, 2011-12-07 21:44:07]

Change committed as 113472