Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Unified Diff: base/callback.h.pump

Issue 8846003: Make callback.h include callback_forward.h and add comments about forward declaration. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/callback.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/callback.h.pump
diff --git a/base/callback.h.pump b/base/callback.h.pump
index aa43ad525bc3137ac60e4c6685e72c71815577f8..76473890378b3814f48acc8261db7726532b5507 100644
--- a/base/callback.h.pump
+++ b/base/callback.h.pump
@@ -16,9 +16,13 @@ $var MAX_ARITY = 7
#define BASE_CALLBACK_H_
#pragma once
+#include "base/callback_forward.h"
#include "base/callback_internal.h"
#include "base/template_util.h"
+// NOTE: Header files that do not require the full definition of Callback or
+// Closure should #include "base/callback_forward.h" instead of this file.
+
// New, super-duper, unified Callback system. This will eventually replace
// NewRunnableMethod, NewRunnableFunction, CreateFunctor, and CreateCallback
// systems currently in the Chromium code base.
@@ -234,6 +238,9 @@ namespace base {
// After this, create template specializations for 0-$(MAX_ARITY) parameters. Note that
// even though the template typelist grows, the specialization still
// only has one type: the function signature.
+//
+// If you are thinking of forward declaring Callback in your own header file,
+// please include "base/callback_forward.h" instead.
template <typename Sig>
class Callback;
« no previous file with comments | « base/callback.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698