Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Unified Diff: ppapi/tests/test_tcp_socket_private_shared.h

Issue 8840007: GetDocumentURL is added to PPB_Testing_Dev. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Fixed codereview issues. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/proxy/ppb_testing_proxy.cc ('k') | ppapi/tests/test_tcp_socket_private_shared.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/tests/test_tcp_socket_private_shared.h
diff --git a/ppapi/tests/test_tcp_socket_private_shared.h b/ppapi/tests/test_tcp_socket_private_shared.h
index 72b43b885aa79344d4869102fe906a024e0d9815..1285102519bcc79ab7d80b9ce845a317bff242c9 100644
--- a/ppapi/tests/test_tcp_socket_private_shared.h
+++ b/ppapi/tests/test_tcp_socket_private_shared.h
@@ -22,14 +22,11 @@ class TestTCPSocketPrivateShared : public TestCase {
void QuitMessageLoop();
private:
- static const char* const kHost;
- static const int kPort = 443;
-
std::string CreateSocket(PP_Resource* socket);
- std::string SyncConnect(PP_Resource socket, const char* host, int port);
+ std::string SyncConnect(PP_Resource socket,
+ const std::string& host, uint16_t port);
std::string SyncConnectWithNetAddress(PP_Resource socket,
const PP_NetAddress_Private& addr);
- std::string SyncSSLHandshake(PP_Resource socket, const char* host, int port);
std::string SyncRead(PP_Resource socket, char* buffer, int32_t num_bytes,
int32_t* bytes_read);
std::string SyncWrite(PP_Resource socket, const char* buffer,
@@ -44,6 +41,8 @@ class TestTCPSocketPrivateShared : public TestCase {
std::string TestReconnect();
const PPB_TCPSocket_Private* tcp_socket_private_interface_;
+ std::string host_;
+ uint16_t port_;
};
#endif // PPAPI_TESTS_TEST_TCP_SOCKET_PRIVATE_SHARED_H_
« no previous file with comments | « ppapi/proxy/ppb_testing_proxy.cc ('k') | ppapi/tests/test_tcp_socket_private_shared.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698