Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: ppapi/tests/test_tcp_socket_private_shared.cc

Issue 8840007: GetDocumentURL is added to PPB_Testing_Dev. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Fixed codereview issues. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/tests/test_tcp_socket_private_shared.h ('k') | ppapi/tests/test_udp_socket_private_shared.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/tests/test_tcp_socket_private_shared.cc
diff --git a/ppapi/tests/test_tcp_socket_private_shared.cc b/ppapi/tests/test_tcp_socket_private_shared.cc
index a05211827ea92f641afb445f0967e7301d0725f7..013aa89d3edb6a3fd9e424ec733c359fd1d077e0 100644
--- a/ppapi/tests/test_tcp_socket_private_shared.cc
+++ b/ppapi/tests/test_tcp_socket_private_shared.cc
@@ -4,9 +4,6 @@
#include "ppapi/tests/test_tcp_socket_private_shared.h"
-#include <string.h>
-#include <new>
-#include <string>
#include <vector>
#include "ppapi/cpp/module.h"
@@ -15,10 +12,6 @@
REGISTER_TEST_CASE(TCPSocketPrivateShared);
-// TODO(ygorshenin): get rid of using external server in tests,
-// http://crbug.com/105863
-const char* const TestTCPSocketPrivateShared::kHost = "www.google.com";
-
TestTCPSocketPrivateShared::TestTCPSocketPrivateShared(
TestingInstance* instance)
: TestCase(instance), tcp_socket_private_interface_(NULL) {
@@ -29,7 +22,16 @@ bool TestTCPSocketPrivateShared::Init() {
pp::Module::Get()->GetBrowserInterface(PPB_TCPSOCKET_PRIVATE_INTERFACE));
if (!tcp_socket_private_interface_)
instance_->AppendError("TCPSocketPrivate interface not available");
- return tcp_socket_private_interface_ && InitTestingInterface();
+
+ bool init_host_port = false;
+ if (!GetLocalHostPort(instance_->pp_instance(), &host_, &port_))
+ instance_->AppendError("Can't init host and port");
+ else
+ init_host_port = true;
+
+ return tcp_socket_private_interface_ &&
+ init_host_port &&
+ InitTestingInterface();
}
void TestTCPSocketPrivateShared::RunTests(const std::string& filter) {
@@ -53,12 +55,12 @@ std::string TestTCPSocketPrivateShared::CreateSocket(PP_Resource* socket) {
}
std::string TestTCPSocketPrivateShared::SyncConnect(PP_Resource socket,
- const char* host,
- int port) {
+ const std::string& host,
+ uint16_t port) {
TestCompletionCallback callback(instance_->pp_instance(), force_async_);
int32_t rv = tcp_socket_private_interface_->Connect(
- socket, host, port,
+ socket, host.c_str(), port,
static_cast<pp::CompletionCallback>(callback).pp_completion_callback());
if (force_async_ && rv != PP_OK_COMPLETIONPENDING)
@@ -88,24 +90,6 @@ std::string TestTCPSocketPrivateShared::SyncConnectWithNetAddress(
PASS();
}
-std::string TestTCPSocketPrivateShared::SyncSSLHandshake(PP_Resource socket,
- const char* host,
- int port) {
- TestCompletionCallback callback(instance_->pp_instance(), force_async_);
-
- int32_t rv = tcp_socket_private_interface_->SSLHandshake(
- socket, host, port,
- static_cast<pp::CompletionCallback>(callback).pp_completion_callback());
-
- if (force_async_ && rv != PP_OK_COMPLETIONPENDING)
- return ReportError("PPB_TCPSocket_Private::SSLHandshake force_async", rv);
- if (rv == PP_OK_COMPLETIONPENDING)
- rv = callback.WaitForResult();
- if (rv != PP_OK)
- return ReportError("PPB_TCPSocket_Private::SSLHandshake", rv);
- PASS();
-}
-
std::string TestTCPSocketPrivateShared::SyncRead(PP_Resource socket,
char* buffer,
int32_t num_bytes,
@@ -189,7 +173,7 @@ std::string TestTCPSocketPrivateShared::TestGetAddress() {
if (!error_message.empty())
return error_message;
- error_message = SyncConnect(socket, kHost, kPort);
+ error_message = SyncConnect(socket, host_, port_);
if (!error_message.empty())
return error_message;
@@ -214,14 +198,11 @@ std::string TestTCPSocketPrivateShared::TestConnect() {
error_message = CreateSocket(&socket);
if (!error_message.empty())
return error_message;
- error_message = SyncConnect(socket, kHost, kPort);
- if (!error_message.empty())
- return error_message;
- error_message = SyncSSLHandshake(socket, kHost, kPort);
+ error_message = SyncConnect(socket, host_, port_);
if (!error_message.empty())
return error_message;
error_message =
- CheckHTTPResponse(socket, "GET /robots.txt\r\n", "HTTP/1.0 200 OK");
+ CheckHTTPResponse(socket, "GET / HTTP/1.0\r\n\r\n", "HTTP/1.0 200 OK");
if (!error_message.empty())
return error_message;
tcp_socket_private_interface_->Disconnect(socket);
@@ -236,10 +217,7 @@ std::string TestTCPSocketPrivateShared::TestReconnect() {
error_message = CreateSocket(&socket);
if (!error_message.empty())
return error_message;
- error_message = SyncConnect(socket, kHost, kPort);
- if (!error_message.empty())
- return error_message;
- error_message = SyncSSLHandshake(socket, kHost, kPort);
+ error_message = SyncConnect(socket, host_, port_);
if (!error_message.empty())
return error_message;
@@ -256,14 +234,14 @@ std::string TestTCPSocketPrivateShared::TestReconnect() {
error_message = SyncConnectWithNetAddress(socket, remote_address);
if (!error_message.empty())
return error_message;
- error_message = SyncSSLHandshake(socket, kHost, kPort);
- if (!error_message.empty())
- return error_message;
- error_message =
- CheckHTTPResponse(socket, "GET /robots.txt\r\n", "HTTP/1.0 200 OK");
+ error_message = CheckHTTPResponse(socket,
+ "GET / HTTP/1.0\r\n\r\n",
+ "HTTP/1.0 200 OK");
if (!error_message.empty())
return error_message;
tcp_socket_private_interface_->Disconnect(socket);
PASS();
}
+
+// TODO(ygorshenin): test SSLHandshake somehow
« no previous file with comments | « ppapi/tests/test_tcp_socket_private_shared.h ('k') | ppapi/tests/test_udp_socket_private_shared.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698