Issue 8839007: Relax test condition to make it less brittle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8839007: Relax test condition to make it less brittle. (Closed)

Created:
9 years ago by ulan

Modified:
9 years ago

Reviewers:
Erik Corry, Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Relax test condition to make it less brittle. BUG= TEST=cctest/test-api/IdleNotificationWithHint Committed: http://code.google.com/p/v8/source/detail?r=10202

Patch Set 1 #

Patch Set 2 : Address comments #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -3 lines)			Patch
	M	test/cctest/test-api.cc	View	1	3 chunks	+5 lines, -1 line	0 comments	Download
	M	test/cctest/test-heap.cc	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ulan

Please take a look. If a full GC happens during the script execution, there is ...

9 years ago (2011-12-07 09:56:45 UTC) #1

Michael Starzinger

9 years ago (2011-12-07 15:03:38 UTC) #2

LGTM. Can we add comments above those two test that they just verify the
contract of the IdleNotification() function and not that it actually does
reasonable work? Because this confused me at first.

Expand Messages | Collapse Messages