Relax test condition to make it less brittle.

test/cctest/test-api.cc

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 13420 matching lines @@
     "  bar();\n"
     "}\n"
     "foo();\n"
     "}\n"
     "eval('(' + outer +')()//@ sourceURL=eval_url');";
   CHECK(CompileRun(source)->IsUndefined());
 }
 
 
 // Test that idle notification can be handled and eventually returns true.
+// This just checks the contract of the IdleNotification() function,
+// and does not verify that it does reasonable work.
 THREADED_TEST(IdleNotification) {
   v8::HandleScope scope;
   LocalContext env;
   CompileRun("function binom(n, m) {"
              "  var C = [[1]];"
              "  for (var i = 1; i <= n; ++i) {"
              "    C[i] = [1];"
              "    for (var j = 1; j < i; ++j) {"
              "      C[i][j] = C[i-1][j-1] + C[i-1][j];"
              "    }"
              "    C[i][i] = 1;"
              "  }"
              "  return C[n][m];"
              "};"
              "binom(1000, 500)");
   bool rv = false;
   for (int i = 0; i < 100; i++) {
     rv = v8::V8::IdleNotification();
     if (rv)
       break;
   }
   CHECK(rv == true);
 }
 
 // Test that idle notification can be handled and eventually returns true.
+// This just checks the contract of the IdleNotification() function,
+// and does not verify that it does reasonable work.
 THREADED_TEST(IdleNotificationWithHint) {
   v8::HandleScope scope;
   LocalContext env;
   CompileRun("function binom(n, m) {"
              "  var C = [[1]];"
              "  for (var i = 1; i <= n; ++i) {"
              "    C[i] = [1];"
              "    for (var j = 1; j < i; ++j) {"
              "      C[i][j] = C[i-1][j-1] + C[i-1][j];"
              "    }"
              "    C[i][i] = 1;"
              "  }"
              "  return C[n][m];"
              "};"
              "binom(1000, 500)");
   bool rv = false;
   intptr_t old_size = HEAP->SizeOfObjects();
   bool no_idle_work = v8::V8::IdleNotification(10);
   for (int i = 0; i < 200; i++) {
     rv = v8::V8::IdleNotification(10);
     if (rv)
       break;
   }
   CHECK(rv == true);
   intptr_t new_size = HEAP->SizeOfObjects();
-  CHECK(no_idle_work || new_size < 3 * old_size / 4);
+  CHECK(no_idle_work || new_size < old_size);
 }
 
 
 static uint32_t* stack_limit;
 
 static v8::Handle<Value> GetStackLimitCallback(const v8::Arguments& args) {
   stack_limit = reinterpret_cast<uint32_t*>(
       i::Isolate::Current()->stack_guard()->real_climit());
   return v8::Undefined();
 }
@@ skipping 2131 matching lines @@
   CHECK(i->Equals(CompileRun("'abcbd'.replace(/b/g,func)[3]")));
 
   // TODO(1547): Make the following also return "i".
   // Calling with environment record as base.
   TestReceiver(o, context->Global(), "func()");
   // Calling with no base.
   TestReceiver(o, context->Global(), "(1,func)()");
 
   foreign_context.Dispose();
 }