Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Issue 8838001: Fix leak in HttpPipelinedHostPoolTest. (Closed)

Created:
9 years ago by James Simonsen
Modified:
9 years ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Fix leak in HttpPipelinedHostPoolTest. BUG=None TEST=net_unittests under valgrind Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113360

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M net/http/http_pipelined_host_pool_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
James Simonsen
9 years ago (2011-12-07 03:45:29 UTC) #1
mmenke
LGTM
9 years ago (2011-12-07 04:41:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonjam@chromium.org/8838001/1
9 years ago (2011-12-07 04:41:44 UTC) #3
commit-bot: I haz the power
Try job failure for 8838001-1 (retry) on mac_rel for step "browser_tests". It's a second try, ...
9 years ago (2011-12-07 06:22:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonjam@chromium.org/8838001/1
9 years ago (2011-12-07 06:29:47 UTC) #5
commit-bot: I haz the power
Change committed as 113360
9 years ago (2011-12-07 07:37:57 UTC) #6
cbentzel
9 years ago (2011-12-07 13:06:14 UTC) #7
Thanks for fixing this.

On Wed, Dec 7, 2011 at 2:37 AM, <commit-bot@chromium.org> wrote:

> Change committed as 113360
>
>
http://codereview.chromium.**org/8838001/<http://codereview.chromium.org/8838...
>

Powered by Google App Engine
This is Rietveld 408576698