net/http/http_pipelined_host_pool_unittest.cc - Issue 8838001: Fix leak in HttpPipelinedHostPoolTest.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/http/http_pipelined_host_pool_unittest.cc

Issue 8838001: Fix leak in HttpPipelinedHostPoolTest. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « no previous file | no next file » | no next file with comments »

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "net/http/http_pipelined_host_pool.h"	5 #include "net/http/http_pipelined_host_pool.h"

6	6

7 #include "base/memory/scoped_ptr.h"	7 #include "base/memory/scoped_ptr.h"

8 #include "net/base/ssl_config_service.h"	8 #include "net/base/ssl_config_service.h"

9 #include "net/http/http_pipelined_host.h"	9 #include "net/http/http_pipelined_host.h"

10 #include "net/http/http_pipelined_host_capability.h"	10 #include "net/http/http_pipelined_host_capability.h"

(...skipping 173 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
184 CreateDummyStream();	184 CreateDummyStream();

185 pool_->OnHostIdle(host_);	185 pool_->OnHostIdle(host_);

186 }	186 }

187	187

188 TEST_F(HttpPipelinedHostPoolTest, PopulatesServerProperties) {	188 TEST_F(HttpPipelinedHostPoolTest, PopulatesServerProperties) {

189 EXPECT_EQ(PIPELINE_UNKNOWN,	189 EXPECT_EQ(PIPELINE_UNKNOWN,

190 http_server_properties_->GetPipelineCapability(host_->origin()));	190 http_server_properties_->GetPipelineCapability(host_->origin()));

191 pool_->OnHostDeterminedCapability(host_, PIPELINE_CAPABLE);	191 pool_->OnHostDeterminedCapability(host_, PIPELINE_CAPABLE);

192 EXPECT_EQ(PIPELINE_CAPABLE,	192 EXPECT_EQ(PIPELINE_CAPABLE,

193 http_server_properties_->GetPipelineCapability(host_->origin()));	193 http_server_properties_->GetPipelineCapability(host_->origin()));

	194 delete host_; // Must manually delete, because it's never added to \|pool_\|.

194 }	195 }

195	196

196 } // anonymous namespace	197 } // anonymous namespace

197	198

198 } // namespace net	199 } // namespace net

OLD	NEW