Issue 8838: Change the fatal error handler to no longer return to V8. It will now crash...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8838: Change the fatal error handler to no longer return to V8. It will now crash... (Closed)

Created:
12 years, 1 month ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Feng Qian

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Change the fatal error handler to no longer return to V8. It will now crash the renderer. Returning as it did before would end up in V8 OS::Abort calling __debugbreak() which would also crask the renderer. I am about to change V8 OS::Abort to call abort() instead of __debugbreak() and Chrome should not depend on how V8 handles aborts anyway. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=4070

Patch Set 1 #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -8 lines)			Patch
	M	webkit/port/bindings/v8/v8_proxy.cpp	View		1 chunk	+8 lines, -8 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages