Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(775)

Unified Diff: webkit/port/bindings/v8/v8_proxy.cpp

Issue 8838: Change the fatal error handler to no longer return to V8. It will now crash... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 12 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/port/bindings/v8/v8_proxy.cpp
===================================================================
--- webkit/port/bindings/v8/v8_proxy.cpp (revision 4069)
+++ webkit/port/bindings/v8/v8_proxy.cpp (working copy)
@@ -788,22 +788,22 @@
ReportUnsafeAccessTo(target, REPORT_LATER);
}
+static void HandleFatalErrorInV8()
+{
+ // TODO: We temporarily deal with V8 internal error situations
+ // such as out-of-memory by crashing the renderer.
+ CRASH();
+}
+
static void ReportFatalErrorInV8(const char* location, const char* message)
{
// V8 is shutdown, we cannot use V8 api.
// The only thing we can do is to disable JavaScript.
// TODO: clean up V8Proxy and disable JavaScript.
printf("V8 error: %s (%s)\n", message, location);
+ HandleFatalErrorInV8();
}
-static void HandleFatalErrorInV8()
-{
- // TODO: We temporarily deal with V8 internal error situations
- // such as out-of-memory by crashing the renderer.
- CRASH();
-}
-
-
V8Proxy::~V8Proxy()
{
clearForClose();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698