Issue 8836007: Convert keysym to keycode for modifiers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8836007: Convert keysym to keycode for modifiers (Closed)

Created:
9 years ago by oshima

Modified:
9 years ago

Reviewers:
Daniel Erat, sky

CC:
chromium-reviews, yusukes+watch_chromium.org, kkania, penghuang+watch_chromium.org, robertshield, Paweł Hajdan Jr., James Su

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Convert keysym to keycode for modifiers Set mask after sending modifier keys. Print unknown keysym in hex and add warning for unknown keycode. BUG=106630 TEST=All BrowserKeyEventsTest except for AccessKey will pass Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113456

Patch Set 1 #

Patch Set 2 : " #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -17 lines)			Patch
	M	chrome/browser/automation/ui_controls_aurax11.cc	View		3 chunks	+19 lines, -15 lines	0 comments	Download
	M	ui/base/keycodes/keyboard_code_conversion_x.cc	View	1	4 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/8836007/2001

9 years ago (2011-12-07 18:28:21 UTC) #5

Change committed as 113456

Expand Messages | Collapse Messages