Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Unified Diff: ui/base/keycodes/keyboard_code_conversion_x.cc

Issue 8836007: Convert keysym to keycode for modifiers (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: " Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/automation/ui_controls_aurax11.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/keycodes/keyboard_code_conversion_x.cc
diff --git a/ui/base/keycodes/keyboard_code_conversion_x.cc b/ui/base/keycodes/keyboard_code_conversion_x.cc
index eda35b46644308acb34d95671e72172e9d921230..d7f83728d3f90891c9107d3e767a363c860d55ae 100644
--- a/ui/base/keycodes/keyboard_code_conversion_x.cc
+++ b/ui/base/keycodes/keyboard_code_conversion_x.cc
@@ -10,6 +10,7 @@
#include "base/basictypes.h"
#include "base/logging.h"
+#include "base/stringprintf.h"
#include "base/utf_string_conversions.h"
namespace ui {
@@ -43,6 +44,7 @@ KeyboardCode KeyboardCodeFromXKeysym(unsigned int keysym) {
return VKEY_DELETE;
case XK_Tab:
case XK_KP_Tab:
+ case XK_ISO_Left_Tab:
return VKEY_TAB;
case XK_Linefeed:
case XK_Return:
@@ -313,8 +315,7 @@ KeyboardCode KeyboardCodeFromXKeysym(unsigned int keysym) {
// TODO(sad): some keycodes are still missing.
}
-
- DLOG(WARNING) << "Unknown keycode: " << keysym;
+ DLOG(WARNING) << "Unknown keysym: " << StringPrintf("0x%x", keysym);
return VKEY_UNKNOWN;
}
@@ -616,6 +617,7 @@ int XKeysymForWindowsKeyCode(KeyboardCode keycode, bool shift) {
return XK_F1 + (keycode - VKEY_F1);
default:
+ LOG(WARNING) << "Unknown keycode:" << keycode;
return 0;
}
}
« no previous file with comments | « chrome/browser/automation/ui_controls_aurax11.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698