Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 8835011: Revert 113282 - Isolates generic DnsClient from AsyncHostResolver. (Closed)

Created:
9 years ago by cbentzel
Modified:
9 years ago
Reviewers:
szym
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, mmenke, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 113282 - Isolates generic DnsClient from AsyncHostResolver. There were a few memory issues including access of unadressable memory. DnsClient provides a generic DNS client that allows fetching resource records. DnsClient is very lightweight and does not support aggregation, queuing or prioritization of requests. This is the first CL in a series to merge AsyncHostResolver into HostResolverImpl. Also introduces general-purpose BigEndianReader/Writer. BUG=90881 TEST=./net_unittests Review URL: http://codereview.chromium.org/8762001 TBR=szym@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113384

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+910 lines, -1948 lines) Patch
D net/base/big_endian.h View 1 chunk +0 lines, -107 lines 0 comments Download
D net/base/big_endian.cc View 1 chunk +0 lines, -98 lines 0 comments Download
D net/base/big_endian_unittest.cc View 1 chunk +0 lines, -100 lines 0 comments Download
M net/base/dns_util.h View 1 chunk +3 lines, -7 lines 0 comments Download
M net/base/dns_util.cc View 4 chunks +8 lines, -9 lines 0 comments Download
M net/dns/async_host_resolver.h View 7 chunks +32 lines, -18 lines 0 comments Download
M net/dns/async_host_resolver.cc View 10 chunks +58 lines, -77 lines 0 comments Download
M net/dns/async_host_resolver_unittest.cc View 6 chunks +67 lines, -96 lines 0 comments Download
D net/dns/dns_client.h View 1 chunk +0 lines, -93 lines 0 comments Download
D net/dns/dns_client.cc View 1 chunk +0 lines, -91 lines 0 comments Download
D net/dns/dns_client_unittest.cc View 1 chunk +0 lines, -311 lines 0 comments Download
D net/dns/dns_protocol.h View 1 chunk +0 lines, -122 lines 0 comments Download
M net/dns/dns_query.h View 2 chunks +27 lines, -12 lines 0 comments Download
M net/dns/dns_query.cc View 1 chunk +61 lines, -48 lines 0 comments Download
M net/dns/dns_query_unittest.cc View 2 chunks +72 lines, -31 lines 0 comments Download
M net/dns/dns_response.h View 1 chunk +13 lines, -79 lines 0 comments Download
M net/dns/dns_response.cc View 1 chunk +68 lines, -156 lines 0 comments Download
M net/dns/dns_response_unittest.cc View 2 chunks +95 lines, -188 lines 0 comments Download
D net/dns/dns_session.h View 1 chunk +0 lines, -70 lines 0 comments Download
D net/dns/dns_session.cc View 1 chunk +0 lines, -47 lines 0 comments Download
M net/dns/dns_test_util.h View 5 chunks +24 lines, -8 lines 0 comments Download
M net/dns/dns_test_util.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M net/dns/dns_transaction.h View 3 chunks +63 lines, -21 lines 0 comments Download
M net/dns/dns_transaction.cc View 9 chunks +122 lines, -62 lines 0 comments Download
M net/dns/dns_transaction_unittest.cc View 9 chunks +183 lines, -89 lines 0 comments Download
M net/net.gyp View 5 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
cbentzel
9 years ago (2011-12-07 13:18:37 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698