Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: net/base/dns_util.h

Issue 8835011: Revert 113282 - Isolates generic DnsClient from AsyncHostResolver. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/big_endian_unittest.cc ('k') | net/base/dns_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/dns_util.h
===================================================================
--- net/base/dns_util.h (revision 113383)
+++ net/base/dns_util.h (working copy)
@@ -19,23 +19,19 @@
//
// dotted: a string in dotted form: "www.google.com"
// out: a result in DNS form: "\x03www\x06google\x03com\x00"
-NET_EXPORT_PRIVATE bool DNSDomainFromDot(const base::StringPiece& dotted,
+NET_EXPORT_PRIVATE bool DNSDomainFromDot(const std::string& dotted,
std::string* out);
// DNSDomainToString coverts a domain in DNS format to a dotted string.
-NET_EXPORT_PRIVATE std::string DNSDomainToString(
- const base::StringPiece& domain);
+NET_EXPORT_PRIVATE std::string DNSDomainToString(const std::string& domain);
// Returns true iff the given character is in the set of valid DNS label
// characters as given in RFC 3490, 4.1, 3(a)
NET_EXPORT_PRIVATE bool IsSTD3ASCIIValidCharacter(char c);
// Returns the hostname by trimming the ending dot, if one exists.
-NET_EXPORT std::string TrimEndingDot(const base::StringPiece& host);
+NET_EXPORT std::string TrimEndingDot(const std::string& host);
-// TODO(szym): remove all definitions below once DnsRRResolver migrates to
-// DnsClient
-
// DNS class types.
static const uint16 kClassIN = 1;
« no previous file with comments | « net/base/big_endian_unittest.cc ('k') | net/base/dns_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698