Issue 8834011: [cros] Postpone call to GetNativeWindow() in NetworkDropdown till it's really needed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8834011: [cros] Postpone call to GetNativeWindow() in NetworkDropdown till it's really needed. (Closed)

Created:
9 years ago by Nikita (slow)

Modified:
9 years ago

Reviewers:
whywhat

CC:
chromium-reviews, nkostylev+watch_chromium.org, dcheng

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

[cros] Postpone call to GetNativeWindow() in NetworkDropdown till it's really needed. Workaround for a crash. BUG=106485 TEST=VMTests, no seg fault. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113394

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -8 lines)			Patch
M	chrome/browser/ui/webui/chromeos/login/network_dropdown.h	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	chrome/browser/ui/webui/chromeos/login/network_dropdown.cc	View	3 chunks	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/webui/chromeos/login/network_dropdown_handler.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/8834011/1

9 years ago (2011-12-07 13:55:03 UTC) #3

Change committed as 113394