Issue 8831002: Android buildbot: be more tolerant of 'stuck' devices.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8831002: Android buildbot: be more tolerant of 'stuck' devices. (Closed)

Created:
9 years ago by John Grabowski

Modified:
9 years ago

Reviewers:
bulach

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Android buildbot: be more tolerant of 'stuck' devices. Be explicit about which device we are 'wait for boot'ing on. Also add explicit timeout on wait-for-boot. BUG=None TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113363

Patch Set 1 #

Total comments: 1

Patch Set 2 : bulach feedback #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -8 lines)			Patch
	M	build/android/emulator.py	View	1	2 chunks	+14 lines, -8 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

bulach

LGTM, one suggestion: http://codereview.chromium.org/8831002/diff/1/build/android/emulator.py File build/android/emulator.py (right): http://codereview.chromium.org/8831002/diff/1/build/android/emulator.py#newcode93 build/android/emulator.py:93: _EMULATOR_WFBC_TIMEOUT = 120 nit: this class ...

9 years ago (2011-12-07 06:27:09 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jrg@chromium.org/8831002/5001

9 years ago (2011-12-07 06:36:15 UTC) #4

Change committed as 113363

Expand Messages | Collapse Messages