Android buildbot: be more tolerant of 'stuck' devices.

build/android/emulator.py

 #!/usr/bin/env python
 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Provides an interface to start and stop Android emulator.
 
 Assumes system environment ANDROID_NDK_ROOT has been set.
 
   Emulator: The class provides the methods to launch/shutdown the emulator with
@@ skipping 63 matching lines @@
 
   Attributes:
     emulator: Path of Android's emulator tool.
     popen: Popen object of the running emulator process.
     device: Device name of this emulator.
   """
 
   # Signals we listen for to kill the emulator on
   _SIGNALS = (signal.SIGINT, signal.SIGHUP)
 
-  # Time to wait for an emulator launch, in seconds.
+  # Time to wait for an emulator launch, in seconds.  This includes
+  # the time to launch the emulator and a wait-for-device command.
   _EMULATOR_LAUNCH_TIMEOUT = 120
 
   # Timeout interval of wait-for-device command before bouncing to a a
   # process life check.
   _EMULATOR_WFD_TIMEOUT = 5
 
+  # Time to wait for a "wait for boot complete" (property set on device).
+  _EMULATOR_WFBC_TIMEOUT = 120

[bulach, 2011/12/07 06:27:09]

nit: this class is called "Emulator", so you could remove the _EMULATOR on all
above constants and avoid WFD / WFBC..

+
   def __init__(self):
     try:
       android_sdk_root = os.environ['ANDROID_SDK_ROOT']
     except KeyError:
       logging.critical('The ANDROID_SDK_ROOT must be set to run the test on '
                        'emulator.')
       raise
     self.emulator = os.path.join(android_sdk_root, 'tools', 'emulator')
     self.popen = None
     self.device = None
@@ skipping 48 matching lines @@
         adb_cmd = "adb -s %s %s" % (self.device, 'kill-server')
         run_command.RunCommand(adb_cmd)
       self.popen.poll()
       if self.popen.returncode != None:
         raise EmulatorLaunchException('EMULATOR DIED')
     if seconds_waited >= self._EMULATOR_LAUNCH_TIMEOUT:
       raise EmulatorLaunchException('TIMEOUT with wait-for-device')
     logging.info('Seconds waited on wait-for-device: %d', seconds_waited)
     # Now that we checked for obvious problems, wait for a boot complete.
     # Waiting for the package manager has been problematic.
-    a.Adb().WaitForBootComplete()
+    a.Adb().SetTargetSerial(self.device)
+    a.Adb().WaitForBootComplete(self._EMULATOR_WFBC_TIMEOUT)
 
   def Shutdown(self):
     """Shuts down the process started by launch."""
     if self.popen:
       self.popen.poll()
       if self.popen.returncode == None:
         self.popen.kill()
       self.popen = None
 
   def _ShutdownOnSignal(self, signum, frame):
     logging.critical('emulator _ShutdownOnSignal')
     for sig in self._SIGNALS:
       signal.signal(sig, signal.SIG_DFL)
     self.Shutdown()
     raise KeyboardInterrupt  # print a stack
 
   def _InstallKillHandler(self):
     """Install a handler to kill the emulator when we exit unexpectedly."""
     for sig in self._SIGNALS:
       signal.signal(sig, self._ShutdownOnSignal)
 
 def main(argv):
   Emulator().launch()
 
 
 if __name__ == '__main__':
   main(sys.argv)