Issue 883001: Porting binary op ICs to arm

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 883001: Porting binary op ICs to arm (Closed)

Created:
10 years, 9 months ago by Vladislav Kaznacheev

Modified:
9 years, 7 months ago

Reviewers:
Kevin Millikin (Chromium), Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Porting binary op ICs to arm Committed: http://code.google.com/p/v8/source/detail?r=4201

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+341 lines, -249 lines)			Patch
	M	src/arm/codegen-arm.h	View	1	3 chunks	+48 lines, -3 lines	0 comments	Download
	M	src/arm/codegen-arm.cc	View	1	6 chunks	+293 lines, -246 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

10 years, 9 months ago (2010-03-22 10:17:50 UTC) #3

LGTM

http://codereview.chromium.org/883001/diff/6001/7001
File src/arm/codegen-arm.cc (right):

http://codereview.chromium.org/883001/diff/6001/7001#newcode6341
src/arm/codegen-arm.cc:6341: // Generate an unreachable reference to the DEFAULT
stub so that it can be
Please add the TODO to get rid of this before submitting and then get rid of
this as a separate change.

Expand Messages | Collapse Messages