Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 8825014: Revert 113300 - Revert of 112134 of Revert 112130 - Close idle connections / SPDY sessions when n... (Closed)

Created:
9 years ago by ramant (doing other things)
Modified:
9 years ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 113300 - Revert of 112134 of Revert 112130 - Close idle connections / SPDY sessions when needed. Due to the idle connection state being held by different socket pools, it's possible for one socket pool to hold an idle socket in a lower layer socket pool. From the lower level socket pool's perspective, the socket is being "actively" used. From the higher socket pool's (including SpdySession, which is more of a connection manager) perspective, the connection is idle and can be closed if we have hit a limit. Normally this isn't a big deal, except when we have a lot of idle SPDY connections and are connecting via a proxy, so we have low connection limits through the proxy server. We address this problem by allowing lower-level socket pools to tell higher level socket pools to close a socket. Fixed ASAN test failures by removing .Times(1) and .Times(2) from CloseMultipleIdleSocketsHeldByLayeredPoolWhenNeeded unittest (this removes the tests relying on the order of std::set in CloseOneIdleConnectionInLayeredPool). ASAN is probably causing the memory allocator to allocate the pools differently. The std::set is ordered by LayeredPool* which is the address of the LayeredPool (willchan). BUG=62364, 92244, 105839 TEST=none Review URL: http://codereview.chromium.org/8340012 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/8745007 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/8803019 TBR=rtenneti@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113305

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -663 lines) Patch
M net/http/http_network_transaction_unittest.cc View 1 chunk +0 lines, -178 lines 0 comments Download
M net/http/http_proxy_client_socket_pool.h View 4 chunks +1 line, -11 lines 0 comments Download
M net/http/http_proxy_client_socket_pool.cc View 4 chunks +2 lines, -34 lines 0 comments Download
M net/socket/client_socket_handle.h View 2 chunks +0 lines, -5 lines 0 comments Download
M net/socket/client_socket_handle.cc View 4 chunks +1 line, -20 lines 0 comments Download
M net/socket/client_socket_pool.h View 3 chunks +0 lines, -21 lines 0 comments Download
M net/socket/client_socket_pool_base.h View 10 chunks +9 lines, -38 lines 0 comments Download
M net/socket/client_socket_pool_base.cc View 9 chunks +13 lines, -68 lines 0 comments Download
M net/socket/client_socket_pool_base_unittest.cc View 13 chunks +18 lines, -167 lines 0 comments Download
M net/socket/socks_client_socket_pool.h View 4 chunks +1 line, -11 lines 0 comments Download
M net/socket/socks_client_socket_pool.cc View 4 chunks +1 line, -26 lines 0 comments Download
M net/socket/ssl_client_socket_pool.h View 4 chunks +0 lines, -10 lines 0 comments Download
M net/socket/ssl_client_socket_pool.cc View 4 chunks +0 lines, -33 lines 0 comments Download
M net/socket/transport_client_socket_pool.h View 2 chunks +0 lines, -6 lines 0 comments Download
M net/socket/transport_client_socket_pool.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M net/spdy/spdy_session.h View 3 chunks +1 line, -6 lines 0 comments Download
M net/spdy/spdy_session.cc View 3 chunks +1 line, -17 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
ramant (doing other things)
9 years ago (2011-12-07 00:39:46 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698