Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 8825007: Native Client side changes for debugging support: stdout/err -> postmessage. (Closed)

Created:
9 years ago by bsy
Modified:
9 years ago
Reviewers:
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Native Client side changes for debugging support: stdout/err -> postmessage. This CL contains NaCl-side changes to allow NACL_EXE_STDOUT and NACL_EXE_STDERR environment variables to be set to "DEBUG_ONLY:dev://postmessage" to have output to those descriptors be sent (via the reverse channel) to the plugin. Once there, Chrome-side changes (in a separate Cr-side CL) will handle the CallOnMainThread etc to PostMessage the data for the JavaScript code to process, e.g., console.log the message. TEST= run_pm_redir_{stdout,stderr}_{fg,bg}_{0,1000,1000000}_chrome_browser_test BUG= http://code.google.com/p/nativeclient/issues/detail?id=2474

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+650 lines, -45 lines) Patch
M SConstruct View 1 chunk +1 line, -0 lines 0 comments Download
M src/shared/platform/nacl_log.h View 1 chunk +1 line, -1 line 0 comments Download
M src/trusted/desc/nacl_desc_base.h View 2 chunks +3 lines, -2 lines 0 comments Download
M src/trusted/desc/nacl_desc_base.c View 2 chunks +2 lines, -0 lines 0 comments Download
M src/trusted/reverse_service/reverse_control_rpc.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/trusted/reverse_service/reverse_service.h View 2 chunks +9 lines, -1 line 0 comments Download
M src/trusted/reverse_service/reverse_service.cc View 3 chunks +30 lines, -0 lines 0 comments Download
M src/trusted/service_runtime/arch/x86_64/sel_ldr_x86_64.c View 1 chunk +1 line, -1 line 0 comments Download
M src/trusted/service_runtime/build.scons View 1 chunk +2 lines, -0 lines 0 comments Download
M src/trusted/service_runtime/nacl_config.h View 2 chunks +3 lines, -3 lines 0 comments Download
A src/trusted/service_runtime/nacl_desc_postmessage.h View 1 chunk +56 lines, -0 lines 0 comments Download
A src/trusted/service_runtime/nacl_desc_postmessage.c View 1 chunk +152 lines, -0 lines 0 comments Download
A src/trusted/service_runtime/nacl_resource.h View 1 chunk +107 lines, -0 lines 0 comments Download
A src/trusted/service_runtime/nacl_resource.c View 1 chunk +182 lines, -0 lines 0 comments Download
M src/trusted/service_runtime/nacl_syscall_common.c View 1 chunk +1 line, -0 lines 0 comments Download
M src/trusted/service_runtime/sel_ldr.h View 3 chunks +9 lines, -0 lines 0 comments Download
M src/trusted/service_runtime/sel_ldr.c View 6 chunks +65 lines, -29 lines 0 comments Download
M src/trusted/service_runtime/sel_main.c View 1 chunk +1 line, -1 line 0 comments Download
M src/trusted/service_runtime/service_runtime.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/browser_tester/browsertester/browserlauncher.py View 1 chunk +22 lines, -7 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698