Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Unified Diff: src/trusted/reverse_service/reverse_service.h

Issue 8825007: Native Client side changes for debugging support: stdout/err -> postmessage. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client/
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/trusted/reverse_service/reverse_control_rpc.h ('k') | src/trusted/reverse_service/reverse_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/trusted/reverse_service/reverse_service.h
===================================================================
--- src/trusted/reverse_service/reverse_service.h (revision 7373)
+++ src/trusted/reverse_service/reverse_service.h (working copy)
@@ -29,7 +29,7 @@
public:
virtual ~ReverseInterface() {}
- // debugging, messaging
+ // For debugging, messaging. |message| goes to JavaScript console.
virtual void Log(nacl::string message) = 0;
// Startup handshake
@@ -60,6 +60,14 @@
// any interested parties.
virtual void ReportExitStatus(int exit_status) = 0;
+ // Standard output and standard error redirection, via setting
+ // NACL_EXE_STDOUT to the string "DEBUG_ONLY:dev://postmessage" (see
+ // native_client/src/trusted/nacl_resource.* and sel_ldr). NB: the
+ // contents of |message| is arbitrary bytes and not an Unicode
+ // string, so the implementation should take care to handle this
+ // appropriately.
+ virtual void PostMessage(nacl::string message); // eventually = 0;
+
// covariant impl of Ref()
ReverseInterface* Ref() { // down_cast
return reinterpret_cast<ReverseInterface*>(RefCountBase::Ref());
« no previous file with comments | « src/trusted/reverse_service/reverse_control_rpc.h ('k') | src/trusted/reverse_service/reverse_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698