Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 8824019: Hide panels in presence of full screen app for windows. (Closed)

Created:
9 years ago by prasadt
Modified:
9 years ago
Reviewers:
jianli
CC:
chromium-reviews, jennb, jianli, Dmitry Titov, dcheng, prasadt
Visibility:
Public.

Description

Hide panels in presence of full screen app for windows. Disabled timer to support full screen detection on Linux as we don't need it there. BUG=102731 TEST=Manual steps in the bug report. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113553

Patch Set 1 #

Patch Set 2 : Disabled timer on Linux. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -5 lines) Patch
M chrome/browser/ui/panels/panel_browser_view.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/panels/panel_browser_view.cc View 1 2 chunks +17 lines, -5 lines 0 comments Download
M chrome/browser/ui/panels/panel_browser_window_gtk.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/panels/panel_manager.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
prasadt
9 years ago (2011-12-07 00:57:47 UTC) #1
prasadt
Made a change to disable timer on Linux.
9 years ago (2011-12-07 21:23:34 UTC) #2
jianli
lgtm
9 years ago (2011-12-07 21:34:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/prasadt@chromium.org/8824019/3001
9 years ago (2011-12-07 21:37:46 UTC) #4
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
9 years ago (2011-12-08 01:31:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/prasadt@chromium.org/8824019/3001
9 years ago (2011-12-08 02:13:19 UTC) #6
commit-bot: I haz the power
9 years ago (2011-12-08 03:36:34 UTC) #7
Change committed as 113553

Powered by Google App Engine
This is Rietveld 408576698