Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1199)

Unified Diff: chrome/browser/ui/panels/panel_manager.cc

Issue 8824019: Hide panels in presence of full screen app for windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Disabled timer on Linux. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/panels/panel_browser_window_gtk.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/panels/panel_manager.cc
diff --git a/chrome/browser/ui/panels/panel_manager.cc b/chrome/browser/ui/panels/panel_manager.cc
index 30eb6cd95df05814e63b4b48a5ebe3500667a3f1..dfadabbaca10786a1984c5de8b3610e1f2941fbb 100644
--- a/chrome/browser/ui/panels/panel_manager.cc
+++ b/chrome/browser/ui/panels/panel_manager.cc
@@ -100,11 +100,16 @@ Panel* PanelManager::CreatePanel(Browser* browser) {
content::Source<Panel>(panel),
content::NotificationService::NoDetails());
+// We don't enable full screen detection for Linux as z-order rules for
+// panels on Linux ensures that they're below any app running in full screen
+// mode.
+#if defined(OS_WIN) || defined(OS_MACOSX)
if (num_panels() == 1) {
full_screen_mode_timer_.Start(FROM_HERE,
base::TimeDelta::FromMilliseconds(kFullScreenModeCheckIntervalMs),
this, &PanelManager::CheckFullScreenMode);
}
+#endif
return panel;
}
@@ -123,8 +128,10 @@ void PanelManager::CheckFullScreenMode() {
}
void PanelManager::Remove(Panel* panel) {
+#if defined(OS_WIN) || defined(OS_MACOSX)
if (num_panels() == 1)
full_screen_mode_timer_.Stop();
+#endif
if (panel_strip_->Remove(panel))
return;
« no previous file with comments | « chrome/browser/ui/panels/panel_browser_window_gtk.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698