Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 8824015: Revert 113290 - Rename the shared_impl resource files to give them more regular names. (Closed)

Created:
9 years ago by brettw
Modified:
9 years ago
Reviewers:
brettw
CC:
chromium-reviews, darin-cc_chromium.org, apatrick_chromium, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 113290 - Rename the shared_impl resource files to give them more regular names. I keep getting confused between things like AudioImpl and PPB_Audio_Impl. This uses _shared for the names, so now we have _impl, _proxy, and _shared which makes more sense. I also removed the ppb_opengles2_impl file since it was just a forward to the shared version. BUG= TEST= Review URL: http://codereview.chromium.org/8790004 TBR=brettw@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113302

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -3321 lines) Patch
M gpu/command_buffer/build_gles2_cmd_buffer.py View 4 chunks +5 lines, -6 lines 0 comments Download
M ppapi/ppapi_shared.gypi View 2 chunks +32 lines, -31 lines 0 comments Download
MM ppapi/proxy/interface_list.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppapi_messages.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppapi_param_traits.h View 1 chunk +1 line, -1 line 0 comments Download
MM ppapi/proxy/ppb_audio_input_proxy.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_audio_proxy.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_file_ref_proxy.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M ppapi/proxy/ppb_graphics_3d_proxy.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_image_data_proxy.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_instance_proxy.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ppapi/proxy/ppb_instance_proxy.cc View 4 chunks +7 lines, -10 lines 0 comments Download
M ppapi/proxy/ppb_testing_proxy.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M ppapi/proxy/ppb_video_decoder_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_video_decoder_proxy.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppp_input_event_proxy.cc View 3 chunks +5 lines, -5 lines 0 comments Download
MM ppapi/proxy/resource_creation_proxy.cc View 10 chunks +16 lines, -16 lines 0 comments Download
A + ppapi/shared_impl/audio_config_impl.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/shared_impl/audio_config_impl.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/shared_impl/audio_impl.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/shared_impl/audio_impl.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/shared_impl/audio_input_impl.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/shared_impl/audio_input_impl.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/shared_impl/char_set_impl.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/shared_impl/char_set_impl.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/shared_impl/crypto_impl.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/shared_impl/file_ref_impl.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/shared_impl/file_ref_impl.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/shared_impl/font_impl.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/shared_impl/font_impl.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/shared_impl/graphics_3d_impl.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/shared_impl/graphics_3d_impl.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/shared_impl/image_data_impl.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/shared_impl/image_data_impl.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/shared_impl/input_event_impl.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/shared_impl/input_event_impl.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/shared_impl/instance_impl.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/shared_impl/instance_impl.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/shared_impl/memory_impl.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/shared_impl/opengles2_impl.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/shared_impl/opengles2_impl.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D ppapi/shared_impl/ppb_audio_config_shared.h View 1 chunk +0 lines, -54 lines 0 comments Download
D ppapi/shared_impl/ppb_audio_config_shared.cc View 1 chunk +0 lines, -80 lines 0 comments Download
D ppapi/shared_impl/ppb_audio_input_shared.h View 1 chunk +0 lines, -91 lines 0 comments Download
D ppapi/shared_impl/ppb_audio_input_shared.cc View 1 chunk +0 lines, -94 lines 0 comments Download
D ppapi/shared_impl/ppb_audio_shared.h View 1 chunk +0 lines, -89 lines 0 comments Download
D ppapi/shared_impl/ppb_audio_shared.cc View 1 chunk +0 lines, -94 lines 0 comments Download
D ppapi/shared_impl/ppb_char_set_shared.h View 1 chunk +0 lines, -33 lines 0 comments Download
D ppapi/shared_impl/ppb_char_set_shared.cc View 1 chunk +0 lines, -154 lines 0 comments Download
D ppapi/shared_impl/ppb_crypto_shared.cc View 1 chunk +0 lines, -36 lines 0 comments Download
D ppapi/shared_impl/ppb_file_ref_shared.h View 1 chunk +0 lines, -66 lines 0 comments Download
D ppapi/shared_impl/ppb_file_ref_shared.cc View 1 chunk +0 lines, -67 lines 0 comments Download
D ppapi/shared_impl/ppb_font_shared.h View 1 chunk +0 lines, -32 lines 0 comments Download
D ppapi/shared_impl/ppb_font_shared.cc View 1 chunk +0 lines, -35 lines 0 comments Download
D ppapi/shared_impl/ppb_graphics_3d_shared.h View 1 chunk +0 lines, -77 lines 0 comments Download
D ppapi/shared_impl/ppb_graphics_3d_shared.cc View 1 chunk +0 lines, -137 lines 0 comments Download
D ppapi/shared_impl/ppb_image_data_shared.h View 1 chunk +0 lines, -31 lines 0 comments Download
D ppapi/shared_impl/ppb_image_data_shared.cc View 1 chunk +0 lines, -28 lines 0 comments Download
D ppapi/shared_impl/ppb_input_event_shared.h View 1 chunk +0 lines, -100 lines 0 comments Download
D ppapi/shared_impl/ppb_input_event_shared.cc View 1 chunk +0 lines, -131 lines 0 comments Download
D ppapi/shared_impl/ppb_instance_shared.h View 1 chunk +0 lines, -24 lines 0 comments Download
D ppapi/shared_impl/ppb_instance_shared.cc View 1 chunk +0 lines, -31 lines 0 comments Download
D ppapi/shared_impl/ppb_memory_shared.cc View 1 chunk +0 lines, -43 lines 0 comments Download
D ppapi/shared_impl/ppb_opengles2_shared.h View 1 chunk +0 lines, -21 lines 0 comments Download
D ppapi/shared_impl/ppb_opengles2_shared.cc View 1 chunk +0 lines, -898 lines 0 comments Download
D ppapi/shared_impl/ppb_url_request_info_shared.h View 1 chunk +0 lines, -136 lines 0 comments Download
D ppapi/shared_impl/ppb_url_request_info_shared.cc View 1 chunk +0 lines, -272 lines 0 comments Download
D ppapi/shared_impl/ppb_url_util_shared.h View 1 chunk +0 lines, -53 lines 0 comments Download
D ppapi/shared_impl/ppb_url_util_shared.cc View 1 chunk +0 lines, -115 lines 0 comments Download
D ppapi/shared_impl/ppb_video_decoder_shared.h View 1 chunk +0 lines, -77 lines 0 comments Download
D ppapi/shared_impl/ppb_video_decoder_shared.cc View 1 chunk +0 lines, -88 lines 0 comments Download
A + ppapi/shared_impl/url_request_info_impl.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/shared_impl/url_request_info_impl.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/shared_impl/url_util_impl.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/shared_impl/url_util_impl.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/shared_impl/video_decoder_impl.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/shared_impl/video_decoder_impl.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
MM ppapi/thunk/ppb_char_set_thunk.cc View 3 chunks +5 lines, -5 lines 0 comments Download
MM ppapi/thunk/ppb_image_data_thunk.cc View 2 chunks +3 lines, -3 lines 0 comments Download
MM ppapi/thunk/ppb_url_request_info_thunk.cc View 1 chunk +1 line, -1 line 0 comments Download
MM ppapi/thunk/ppb_url_util_thunk.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M webkit/glue/webkit_glue.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/plugin_module.cc View 3 chunks +3 lines, -3 lines 0 comments Download
MM webkit/plugins/ppapi/ppapi_plugin_instance.h View 2 chunks +2 lines, -2 lines 0 comments Download
MM webkit/plugins/ppapi/ppapi_plugin_instance.cc View 6 chunks +14 lines, -15 lines 0 comments Download
M webkit/plugins/ppapi/ppb_audio_impl.h View 2 chunks +5 lines, -5 lines 0 comments Download
M webkit/plugins/ppapi/ppb_audio_input_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
MM webkit/plugins/ppapi/ppb_file_ref_impl.h View 3 chunks +3 lines, -3 lines 0 comments Download
MM webkit/plugins/ppapi/ppb_file_ref_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
MM webkit/plugins/ppapi/ppb_font_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
MM webkit/plugins/ppapi/ppb_graphics_3d_impl.h View 3 chunks +3 lines, -3 lines 0 comments Download
MM webkit/plugins/ppapi/ppb_image_data_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
A + webkit/plugins/ppapi/ppb_opengles_impl.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/plugins/ppapi/ppb_opengles_impl.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
MM webkit/plugins/ppapi/ppb_url_loader_impl.h View 1 chunk +1 line, -1 line 0 comments Download
MM webkit/plugins/ppapi/ppb_url_request_info_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
MM webkit/plugins/ppapi/ppb_url_request_info_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
MM webkit/plugins/ppapi/ppb_video_decoder_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
MM webkit/plugins/ppapi/ppb_video_decoder_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
MM webkit/plugins/ppapi/resource_creation_impl.cc View 6 chunks +11 lines, -11 lines 0 comments Download
MM webkit/plugins/ppapi/url_request_info_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
brettw
9 years ago (2011-12-07 00:01:05 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698