Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 8824010: Put test that is dependent on switch in its own TEST_F(). (Closed)

Created:
9 years ago by miket_OOO
Modified:
9 years ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews, jstritar+watch_chromium.org, mihaip+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Put test that is dependent on switch in its own TEST_F(). BUG=lint from review 8561031 TEST=none; this is a refactoring of existing unit tests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113318

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M chrome/common/extensions/extension_manifests_unittest.cc View 3 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
miket_OOO
9 years ago (2011-12-06 22:24:02 UTC) #1
Aaron Boodman
Thanks, LGTM
9 years ago (2011-12-06 23:59:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miket@chromium.org/8824010/1
9 years ago (2011-12-07 00:00:38 UTC) #3
commit-bot: I haz the power
9 years ago (2011-12-07 01:26:39 UTC) #4
Change committed as 113318

Powered by Google App Engine
This is Rietveld 408576698