Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5167)

Unified Diff: chrome/common/extensions/extension_manifests_unittest.cc

Issue 8824010: Put test that is dependent on switch in its own TEST_F(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension_manifests_unittest.cc
diff --git a/chrome/common/extensions/extension_manifests_unittest.cc b/chrome/common/extensions/extension_manifests_unittest.cc
index 8136deaf04142acfaa504971784430cb84794093..9dd988cd30e8a700f78b8d027629b1d423dc8e9e 100644
--- a/chrome/common/extensions/extension_manifests_unittest.cc
+++ b/chrome/common/extensions/extension_manifests_unittest.cc
@@ -380,7 +380,6 @@ TEST_F(ExtensionManifestTest, AppWebUrls) {
TEST_F(ExtensionManifestTest, AppLaunchContainer) {
scoped_refptr<Extension> extension;
- CommandLine::ForCurrentProcess()->AppendSwitch(switches::kEnablePlatformApps);
extension = LoadAndExpectSuccess("launch_tab.json");
EXPECT_EQ(extension_misc::LAUNCH_TAB, extension->launch_container());
@@ -401,8 +400,6 @@ TEST_F(ExtensionManifestTest, AppLaunchContainer) {
errors::kInvalidLaunchContainer);
LoadAndExpectError("launch_container_invalid_type.json",
errors::kInvalidLaunchContainer);
- LoadAndExpectError("launch_container_invalid_type_for_platform.json",
- errors::kInvalidLaunchContainerForPlatform);
LoadAndExpectError("launch_container_invalid_value.json",
errors::kInvalidLaunchContainer);
LoadAndExpectError("launch_container_without_launch_url.json",
@@ -417,6 +414,13 @@ TEST_F(ExtensionManifestTest, AppLaunchContainer) {
errors::kInvalidLaunchHeight);
}
+TEST_F(ExtensionManifestTest, PlatformAppLaunchContainer) {
+ CommandLine::ForCurrentProcess()->AppendSwitch(switches::kEnablePlatformApps);
+
+ LoadAndExpectError("launch_container_invalid_type_for_platform.json",
+ errors::kInvalidLaunchContainerForPlatform);
+}
+
TEST_F(ExtensionManifestTest, AppLaunchURL) {
LoadAndExpectError("launch_path_and_url.json",
errors::kLaunchPathAndURLAreExclusive);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698