Use preallocated StackOverflowException

runtime/vm/object_store.cc

Index: runtime/vm/object_store.cc
===================================================================
--- runtime/vm/object_store.cc	(revision 2103)
+++ runtime/vm/object_store.cc	(working copy)
@@ -4,6 +4,7 @@
 
 #include "vm/object_store.h"
 
+#include "vm/exceptions.h"
 #include "vm/isolate.h"
 #include "vm/object.h"
 #include "vm/raw_object.h"
@@ -48,7 +49,9 @@
     registered_libraries_(Library::null()),
     pending_classes_(Array::null()),
     sticky_error_(String::null()),
-    empty_context_(Context::null()) {
+    empty_context_(Context::null()),
+    stack_overflow_(Instance::null()),
+    preallocate_objects_called_(false) {
 }
 
 
@@ -69,6 +72,19 @@
 }
 
 
+void ObjectStore::PreallocateObjects() {
+  if (preallocate_objects_called_) {
+    return;
+  }
+  preallocate_objects_called_ = true;
+
+  GrowableArray<const Object*> args;
+  const Instance& exception =
+      Instance::Handle(Exceptions::Create(Exceptions::kStackOverflow, args));

[siva, 2011/12/06 20:44:05]

Since this runs dart code there is a possibility that this code could do a
longjmp. Is long_jmp_base set at this point?

I am also wondering if this function should return an error when that happens
and we could return that error from CheckIsolateState.

[turnidge, 2011/12/06 22:51:09]

Added LongJump around the call.  The error is propagated to the caller in
object_store->sticky_error().  Changed the caller to check this value.

+  set_stack_overflow(exception);
+}
+
+
 RawClass* ObjectStore::GetClass(int index) {
   switch (index) {
     case kObjectClass: return object_class_;