[cros] Profile image downloader is always reset after a download.

chrome/browser/chromeos/login/user.h

Index: chrome/browser/chromeos/login/user.h
diff --git a/chrome/browser/chromeos/login/user.h b/chrome/browser/chromeos/login/user.h
index 53c14678edb53337344390e8d993b856e27bf722..82d2e32656fcc3bbed28512aa3fec23cf7390a62 100644
--- a/chrome/browser/chromeos/login/user.h
+++ b/chrome/browser/chromeos/login/user.h
@@ -53,6 +53,9 @@ class User {
   const SkBitmap& image() const { return image_; }
   int image_index() const { return image_index_; }
 
+  // True if user image is a stub (while real image is being loaded from file).
+  bool image_is_stub() const { return image_is_stub_; }

[whywhat, 2011/12/06 17:51:31]

optional: rename method to is_image_downloading()?

[Ivan Korotkov, 2011/12/08 10:52:20]

This isn't actually User's knowledge if image is downloading or not, just that
we've set a stub image previously.

+
   // OAuth token status for this user.
   OAuthTokenStatus oauth_token_status() const { return oauth_token_status_; }
 
@@ -68,6 +71,8 @@ class User {
 
   // Setters are private so only UserManager can call them.
   void SetImage(const SkBitmap& image, int image_index);
+  // Sets a stub image until the next |SetImage| call.
+  void SetStubImage(int image_index);

[whywhat, 2011/12/06 17:51:31]

Document what index is.

[Ivan Korotkov, 2011/12/08 10:52:20]

Done.

 
   void set_oauth_token_status(OAuthTokenStatus status) {
     oauth_token_status_ = status;
@@ -87,6 +92,9 @@ class User {
   // |kProfileImageIndex|.
   int image_index_;
 
+  // This is true after a |SetStubImage| call and until a |SetImage| call.

[whywhat, 2011/12/06 17:51:31]

nit: sounds kind of hacky, no? Could it be "True if we're in the process of
downloading profile picture and have set a white ghost avatar as user picture
for the time being."

[Ivan Korotkov, 2011/12/08 10:52:20]

Rephrased.

+  bool image_is_stub_;
+
   DISALLOW_COPY_AND_ASSIGN(User);
 };