[cros] Profile image downloader is always reset after a download.

chrome/browser/chromeos/login/user.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_LOGIN_USER_H_
 #define CHROME_BROWSER_CHROMEOS_LOGIN_USER_H_
 #pragma once
 
 #include <string>
 #include <vector>
@@ skipping 35 matching lines @@
   // this user from the other one with the same display name.
   std::string GetNameTooltip() const;
 
   // Returns true if some users have same display name.
   bool NeedsNameTooltip() const;
 
   // The image for this user.
   const SkBitmap& image() const { return image_; }
   int image_index() const { return image_index_; }
 
+  // True if user image is a stub (while real image is being loaded from file).
+  bool image_is_stub() const { return image_is_stub_; }

[whywhat, 2011/12/06 17:51:31]

optional: rename method to is_image_downloading()?

[Ivan Korotkov, 2011/12/08 10:52:20]

This isn't actually User's knowledge if image is downloading or not, just that
we've set a stub image previously.

+
   // OAuth token status for this user.
   OAuthTokenStatus oauth_token_status() const { return oauth_token_status_; }
 
   // The displayed (non-canonical) user email.
   std::string display_email() const { return display_email_; }
 
  private:
   friend class UserManager;
 
   // Do not allow anyone else to create new User instances.
   explicit User(const std::string& email);
   ~User();
 
   // Setters are private so only UserManager can call them.
   void SetImage(const SkBitmap& image, int image_index);
+  // Sets a stub image until the next |SetImage| call.
+  void SetStubImage(int image_index);

[whywhat, 2011/12/06 17:51:31]

Document what index is.

[Ivan Korotkov, 2011/12/08 10:52:20]

Done.

 
   void set_oauth_token_status(OAuthTokenStatus status) {
     oauth_token_status_ = status;
   }
 
   void set_display_email(const std::string& display_email) {
     display_email_ = display_email;
   }
 
   std::string email_;
   // The displayed user email, defaults to |email_|.
   std::string display_email_;
   SkBitmap image_;
   OAuthTokenStatus oauth_token_status_;
 
   // Either index of a default image for the user, |kExternalImageIndex| or
   // |kProfileImageIndex|.
   int image_index_;
 
+  // This is true after a |SetStubImage| call and until a |SetImage| call.

[whywhat, 2011/12/06 17:51:31]

nit: sounds kind of hacky, no? Could it be "True if we're in the process of
downloading profile picture and have set a white ghost avatar as user picture
for the time being."

[Ivan Korotkov, 2011/12/08 10:52:20]

Rephrased.

+  bool image_is_stub_;
+
   DISALLOW_COPY_AND_ASSIGN(User);
 };
 
 // List of known users.
 typedef std::vector<User*> UserList;
 
 }  // namespace chromeos
 
 #endif  // CHROME_BROWSER_CHROMEOS_LOGIN_USER_H_